Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!eu.feeder.erje.net!xlned.com!feeder5.xlned.com!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; '+++': 0.03; 'argument': 0.05; 'insert': 0.05; 'skip:\xa0 30': 0.05; '-0500': 0.09; 'git': 0.09; 'trailing': 0.09; 'cc:addr:python-list': 0.11; '>>': 0.16; "(it's": 0.16; 'cc:name:python list': 0.16; 'cleaner': 0.16; 'to:addr:python.list': 0.16; 'to:addr:tim.thechases.com': 0.16; 'to:name:tim chase': 0.16; 'wrote:': 0.18; 'skip:f 30': 0.19; 'thu,': 0.19; 'cc:addr:python.org': 0.22; 'cc:2**1': 0.23; 'parse': 0.24; 'helpful': 0.24; '---': 0.24; '>': 0.26; 'header :In-Reply-To:1': 0.27; 'am,': 0.29; 'tim': 0.29; '8bit%:3': 0.30; 'message-id:@mail.gmail.com': 0.30; 'easier': 0.31; 'chase': 0.31; 'thanks!': 0.32; "i'd": 0.34; 'could': 0.34; 'skip:s 30': 0.35; 'something': 0.35; 'received:google.com': 0.35; 'add': 0.35; 'keyword': 0.36; 'jason': 0.38; 'skip:& 20': 0.39; '8bit%:6': 0.40; 'everything,': 0.84; 'otten': 0.84; 'try.': 0.91; 'incredibly': 0.96; '2013': 0.98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=J7UCnE6clf1thKFrkIxu9qpq9Zd3j4/mU7snqrJ+FJA=; b=IEPH2rFM1XYJ0e9i+5PdkcYvN/t7jDTQu0dLQ00hhVJgf05aPOlVz82Nyg7nfvnLr2 vVo0NRzju0jag+mej/RZ22AuLpZTHc3gZnRr/gJ3Pqxind/eGistIuinmRn6wQ4DJi5U V15p8tkma7sj9VWCICoInx6NwIqD+9Ek/4a0oCorpo6fi1w/+3fjYqWi/vrybiQ9apYo MVgxFZZ4FVR7yDSed02SimdZG6+7zOxqJa9kmE5vIZhFVvVRFMjhNZG8HFUmMqKsNVZB 7iLpY4ljTYzWQ2h0+raV9F+BUWqbseeo5R59KyB6mjtBTVD4FpBBhx0Bk3tSPYolDscR TEgQ== MIME-Version: 1.0 X-Received: by 10.50.114.37 with SMTP id jd5mr3917897igb.2.1365077917386; Thu, 04 Apr 2013 05:18:37 -0700 (PDT) In-Reply-To: <20130404060913.2e771293@bigbox.christie.dr> References: <515cd919$0$29966$c3e8da3$5496439d@news.astraweb.com> <20130404060913.2e771293@bigbox.christie.dr> Date: Thu, 4 Apr 2013 08:18:37 -0400 Subject: Re: In defence of 80-char lines From: Jason Swails To: Tim Chase Content-Type: multipart/alternative; boundary=047d7b3a98ac5b5fed04d987f8b1 Cc: python list X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 139 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1365077925 news.xs4all.nl 6891 [2001:888:2000:d::a6]:49616 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:42750 --047d7b3a98ac5b5fed04d987f8b1 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Apr 4, 2013 at 7:09 AM, Tim Chase wrote: > On 2013-04-04 08:43, Peter Otten wrote: > > llanitedave wrote: > >> self.mainLabel.SetFont(wx.Font(12, wx.DEFAULT, wx.NORMAL, wx.BOLD, > faceName = "FreeSans")) > > > > I think I would prefer > > > > labelfont = wx.Font( > > pointSize=12, > > style=wx.DEFAULT, > > family=wx.NORMAL, > > weight=wx.BOLD, > > faceName="FreeSans") > > self.mainLabel.SetFont(labelfont) > > +1 > The only change I'd make to this suggestion would be to add a > semi-superfluous comma+newline after the last keyword argument too: > > labelfont = wx.Font( > pointSize=12, > style=wx.DEFAULT, > family=wx.NORMAL, > weight=wx.BOLD, > faceName="FreeSans", > ) > > which makes diffs cleaner when you need to insert something after > faceName: > > --- peter1.txt 2013-04-04 06:03:01.420762566 -0500 > +++ peter2.txt 2013-04-04 06:03:34.736762582 -0500 > @@ -3,4 +3,5 @@ > style=wx.DEFAULT, > family=wx.NORMAL, > weight=wx.BOLD, > - faceName="FreeSans") > + faceName="FreeSans", > + otherValue=42) > > vs. > > --- tkc1.txt 2013-04-04 06:02:52.436762562 -0500 > +++ tkc2.txt 2013-04-04 06:03:51.392762588 -0500 > @@ -4,4 +4,5 @@ > family=wx.NORMAL, > weight=wx.BOLD, > faceName="FreeSans", > + otherValue=42, > ) > +1 I wasn't aware you could do this (superfluous trailing commas), although I admit it hadn't occurred to me to try. I use git for virtually everything, and I regularly parse diffstats -- this would make them much easier to grok. (It's an incredibly helpful bug-tracking technique) Thanks! Jason --047d7b3a98ac5b5fed04d987f8b1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

<= /div>
On Thu, Apr 4, 2= 013 at 7:09 AM, Tim Chase <python.list@tim.thechases.com&g= t; wrote:
On 2013-04-04 08:43, Peter Otten wrote:
> llanitedave wrote:
>> self.mainLabel.SetFont(wx.Font(12, wx.DEFAULT, wx.NORMAL, wx.BOLD,= faceName =3D "FreeSans"))
>
> I think I would prefer
>
> labelfont =3D wx.Font(
> =A0 =A0 pointSize=3D12,
> =A0 =A0 style=3Dwx.DEFAULT,
> =A0 =A0 family=3Dwx.NORMAL,
> =A0 =A0 weight=3Dwx.BOLD,
> =A0 =A0 faceName=3D"FreeSans")
> self.mainLabel.SetFont(labelfont)

+1
The only change I'd make to this suggestion would be to add a
semi-superfluous comma+newline after the last keyword argument too:

=A0labelfont =3D wx.Font(
=A0 =A0 =A0pointSize=3D12,
=A0 =A0 =A0style=3Dwx.DEFAULT,
=A0 =A0 =A0family=3Dwx.NORMAL,
=A0 =A0 =A0weight=3Dwx.BOLD,
=A0 =A0 =A0faceName=3D"FreeSans",
=A0 =A0 =A0)

which makes diffs cleaner when you need to insert something after
faceName:

--- peter1.txt =A02013-04-04 06:03:01.420762566 -0500
+++ peter2.txt =A02013-04-04 06:03:34.736762582 -0500
@@ -3,4 +3,5 @@
=A0 =A0 =A0style=3Dwx.DEFAULT,
=A0 =A0 =A0family=3Dwx.NORMAL,
=A0 =A0 =A0weight=3Dwx.BOLD,
- =A0 =A0faceName=3D"FreeSans")
+ =A0 =A0faceName=3D"FreeSans",
+ =A0 =A0otherValue=3D42)

vs.

--- tkc1.txt =A0 =A02013-04-04 06:02:52.436762562 -0500
+++ tkc2.txt =A0 =A02013-04-04 06:03:51.392762588 -0500
@@ -4,4 +4,5 @@
=A0 =A0 =A0family=3Dwx.NORMAL,
=A0 =A0 =A0weight=3Dwx.BOLD,
=A0 =A0 =A0faceName=3D"FreeSans",
+ =A0 =A0otherValue=3D42,
=A0 =A0 =A0)

+1

I wasn't aware you could do this (superfluous trailing commas), al= though I admit it hadn't occurred to me to try. =A0I use git for virtua= lly everything, and I regularly parse diffstats -- this would make them muc= h easier to grok. =A0(It's an incredibly helpful bug-tracking technique= )

Thanks!
Jason
--047d7b3a98ac5b5fed04d987f8b1--