Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!rt.uk.eu.org!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Date: Tue, 23 Apr 2013 03:03:25 +0100
From: MRAB <python@mrabarnett.plus.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
MIME-Version: 1.0
To: python-list@python.org
Subject: Re: optomizations
References: <CABRP1o_ab1w91jHQN_9cFMAj=rpY3GVUMcKOA9+_TskRMUu=CQ@mail.gmail.com>
In-Reply-To: <CABRP1o_ab1w91jHQN_9cFMAj=rpY3GVUMcKOA9+_TskRMUu=CQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Reply-To: python-list@python.org
Newsgroups: comp.lang.python
Message-ID: <mailman.947.1366682596.3114.python-list@python.org>
Lines: 76
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:44134

On 23/04/2013 02:19, Rodrick Brown wrote:
> I would like some feedback on possible solutions to make this script run
> faster.
> The system is pegged at 100% CPU and it takes a long time to complete.
>
>
> #!/usr/bin/env python
>
> import gzip
> import re
> import os
> import sys
> from datetime import datetime
> import argparse
>
> if __name__ == '__main__':
>      parser = argparse.ArgumentParser()
>      parser.add_argument('-f', dest='inputfile', type=str, help='data file to parse')
>      parser.add_argument('-o', dest='outputdir', type=str, default=os.getcwd(), help='Output directory')
>      args = parser.parse_args()
>
>      if len(sys.argv[1:]) < 1:
>          parser.print_usage()
>          sys.exit(-1)
>
>      print(args)
>      if args.inputfile and os.path.exists(args.inputfile):
>          try:
>              with gzip.open(args.inputfile) as datafile:
>                  for line in datafile:
>                      line = line.replace('mediacdn.xxx.com', 'media.xxx.com')
>                      line = line.replace('staticcdn.xxx.co.uk', 'static.xxx.co.uk')

These next 2 lines are duplicates; the second will have no effect (I
think!).

>                      line = line.replace('cdn.xxx', 'www.xxx')
>                      line = line.replace('cdn.xxx', 'www.xxx')

Won't the next line also do the work of the preceding 2 lines?

>                      line = line.replace('cdn.xx', 'www.xx')
>                      siteurl = line.split()[6].split('/')[2]
>                      line = re.sub(r'\bhttps?://%s\b' % siteurl, "", line, 1)
>
>                      (day, month, year, hour, minute, second) = (line.split()[3]).replace('[','').replace(':','/').split('/')
>                      datelog = '{} {} {}'.format(month, day, year)
>                      dateobj = datetime.strptime(datelog, '%b %d %Y')
>
>                      outfile = '{}{}{}_combined.log'.format(dateobj.year, dateobj.month, dateobj.day)
>                      outdir = (args.outputdir + os.sep + siteurl)
>
>                      if not os.path.exists(outdir):
>                          os.makedirs(outdir)
>
>                      with open(outdir + os.sep + outfile, 'w+') as outf:
>                          outf.write(line)
>
>          except IOError, err:
>              sys.stderr.write("Error unable to read or extract inputfile: {} {}\n".format(args.inputfile, err))
>              sys.exit(-1)
>
I wonder whether it'll make a difference if you read a chunk at a time
(datafile.read(chunk_size) + datafile.readline() to ensure you have
complete lines), perform the replacements on it (so that you're working 
on several lines in one go), and then split it into lines for further
processing.

Another thing you could try caching the result of parsing the date, 
using (month, day, year) the key and outfile as the value in a dict.

A third thing you could try is not writing a file for every line
(doesn't the 'w+' mode truncate the file?), but save the output for
each chunk (see first suggestion) and then write the files afterwards,
at the end of the chunk.