Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed4.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; '+++': 0.03; 'parameters': 0.04; 'argument': 0.05; 'insert': 0.05; '-0500': 0.09; 'arguments': 0.09; 'cc:addr:python-list': 0.11; '-tkc': 0.16; 'cleaner': 0.16; 'from:addr:python.list': 0.16; 'from:addr:tim.thechases.com': 0.16; 'from:name:tim chase': 0.16; 'tempted': 0.16; 'to:addr:web.de': 0.16; 'wrote:': 0.18; 'cc:addr:python.org': 0.22; '---': 0.24; 'cc:2**0': 0.24; 'cc:no real name:2**0': 0.24; 'header:In-Reply-To:1': 0.27; 'properties': 0.29; 'css': 0.30; 'ease': 0.30; "i'd": 0.34; 'skip:s 30': 0.35; 'something': 0.35; 'add': 0.35; 'there': 0.35; 'keyword': 0.36; 'charset:us-ascii': 0.36; 'should': 0.36; 'how': 0.40; 'tracking': 0.61; 'otten': 0.84; 'received:50.22': 0.84 Date: Thu, 4 Apr 2013 06:09:13 -0500 From: Tim Chase To: Peter Otten <__peter__@web.de> Subject: Re: In defence of 80-char lines In-Reply-To: References: <515cd919$0$29966$c3e8da3$5496439d@news.astraweb.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - boston.accountservergroup.com X-AntiAbuse: Original Domain - python.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tim.thechases.com Cc: python-list@python.org X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 58 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1365073656 news.xs4all.nl 6865 [2001:888:2000:d::a6]:35131 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:42746 On 2013-04-04 08:43, Peter Otten wrote: > llanitedave wrote: >> self.mainLabel.SetFont(wx.Font(12, wx.DEFAULT, wx.NORMAL, wx.BOLD, faceName = "FreeSans")) > > I think I would prefer > > labelfont = wx.Font( > pointSize=12, > style=wx.DEFAULT, > family=wx.NORMAL, > weight=wx.BOLD, > faceName="FreeSans") > self.mainLabel.SetFont(labelfont) +1 The only change I'd make to this suggestion would be to add a semi-superfluous comma+newline after the last keyword argument too: labelfont = wx.Font( pointSize=12, style=wx.DEFAULT, family=wx.NORMAL, weight=wx.BOLD, faceName="FreeSans", ) which makes diffs cleaner when you need to insert something after faceName: --- peter1.txt 2013-04-04 06:03:01.420762566 -0500 +++ peter2.txt 2013-04-04 06:03:34.736762582 -0500 @@ -3,4 +3,5 @@ style=wx.DEFAULT, family=wx.NORMAL, weight=wx.BOLD, - faceName="FreeSans") + faceName="FreeSans", + otherValue=42) vs. --- tkc1.txt 2013-04-04 06:02:52.436762562 -0500 +++ tkc2.txt 2013-04-04 06:03:51.392762588 -0500 @@ -4,4 +4,5 @@ family=wx.NORMAL, weight=wx.BOLD, faceName="FreeSans", + otherValue=42, ) Additionally, if there are lots of keyword parameters like this, I'd be tempted to keep them in sorted order for ease of tracking them down (though CSS has long-standing arguments on how properties should be ordered, so to each their own on this). -tkc