Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!gegeweb.org!de-l.enfer-du-nord.net!feeder2.enfer-du-nord.net!feeder.news-service.com!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
Sender: chris@rebertia.com
In-Reply-To: <52c256ae-81b0-4a7c-9047-42e1ae8b6eda@n19g2000prh.googlegroups.com>
References: <52c256ae-81b0-4a7c-9047-42e1ae8b6eda@n19g2000prh.googlegroups.com>
Date: Sat, 10 Sep 2011 00:40:51 -0700
Subject: Re: Applying a function recursively
From: Chris Rebert <clp2@rebertia.com>
To: hetchkay <hetchkay@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: python-list@python.org
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.927.1315640455.27778.python-list@python.org>
Lines: 55
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:13053

On Sat, Sep 10, 2011 at 12:19 AM, hetchkay <hetchkay@gmail.com> wrote:
> Hi,
> I want to apply a "convert" function on an object as follows:
> If the object is of MyType type, invoke the passed in function.
> If the object is a dictionary, apply on the keys and values of the
> dictionary recursively.
> If the object is a set, list or tuple, apply on each element
> recursively.
> Else, leave the object as is.
>
> I wrote the following code:
> def convert(obj, func):
> =C2=A0 if isinstance(obj, MyType):
> =C2=A0 =C2=A0 =C2=A0return func(obj)
> =C2=A0 elif isinstance(obj, dict):
> =C2=A0 =C2=A0 =C2=A0return dict((convert(key, func), convert(value, func)=
) for key,
> value in obj.iteritems())
> =C2=A0 elif isinstance(obj, (list, tuple, set)):
> =C2=A0 =C2=A0 =C2=A0return obj.__class__(convert(x, func) for x in obj)
> =C2=A0 else:
> =C2=A0 =C2=A0 =C2=A0return obj
>
> Is there a better way to do this?

None comes to mind.

> Is there any way I can make this code faster?

Possibly, but it involves ignoring subclasses, and may not actually be
faster in your particular case (it comes down to additional function
calls vs. cost of if-elif-else chain). It would be along the lines of:

def convert_mytype(obj, func):
    return func(obj)

def convert_dict(obj, func):
    return dict((convert(key, func), convert(value, func)) for key,
value in obj.iteritems())

def dont_convert(obj, func):
    return obj

TYPE2FUNC =3D {MyType : convert_mytype, dict : convert_dict, ... }

def convert(obj, func):
    return TYPE2FUNC.get(type(obj), dont_convert)(obj, func)


As they say though, premature optimization is the root of all evil.

Cheers,
Chris
--
http://rebertia.com