Path: csiph.com!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder1.hal-mli.net!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <CAN1F8qVaeyOmbOr0FYN75hYnLBZY7crC+d0HB97jXKjSi7ALqg@mail.gmail.com>
References: <lennh4$kpm$1@cabale.usenet-fr.net> <CAPTjJmomgZSFj7TanBn8_qXP4ULhCm85abJ5=2PcikXJkrH6GQ@mail.gmail.com> <CAN1F8qU8AJ+Z-Rb4+wGsYWd_bS5aOA3bsjd5NjF46MUvnecSeQ@mail.gmail.com> <CAPTjJmoCK9YT5_rNQdNqr+VXGAKUuo5Pbfhk4ouBHecHXPBc4A@mail.gmail.com> <CAN1F8qXHi2b+2HzQWD-6PybOCf7pPgUQ93-Giw7+Rk=jTRpkMw@mail.gmail.com> <CAPTjJmr=eyUb6BxUYC0y8qY75_qeCEYAmnJzM0B_6o20RW+S+Q@mail.gmail.com> <CAN1F8qVaeyOmbOr0FYN75hYnLBZY7crC+d0HB97jXKjSi7ALqg@mail.gmail.com>
Date: Mon, 10 Mar 2014 07:06:37 +1100
Subject: Re: Tuples and immutability
From: Chris Angelico <rosuav@gmail.com>
Cc: "python-list@python.org" <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.7962.1394395600.18130.python-list@python.org>
Lines: 34
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:68090

On Mon, Mar 10, 2014 at 6:57 AM, Joshua Landau <joshua@landau.ws> wrote:
> I would probably implement it closer to home. Inside
> tuple.__getitem__, there would be something like
>
>     if context_is_augmented_assignment():
>         raise TypeError(message+warning)
>     else:
>         raise TypeError(message)
>
> which would have much lower technical costs. It does depend on how
> costly "context_is_augmented_assignment" is, though. A speed argument
> is totally valid, but I'd hope it's possible to work around.

Yeah, I'm not sure there's an easy way to tell the tuple that it's an
augmented assignment. You might be able to look at the backtrace, but
that's tricky.

In theory, you could catch TypeError after any augmented assignment,
and check several things:
1) The target object does not have __setitem__
2) The object being manipulated does have __iadd__ (or corresponding for others)
3) The error is that item assignment is not possible

and if all three are the case, then add a tag to the message. But this
is best done by catching the exception. Otherwise you'd be limiting
this to tuples and lists; not to mention that this is really only an
issue of error reporting, and correct code shouldn't be tripping this
at all. So put a check like that at the place where you display the
error, if you can. The AST transform that I described would also work.

But I really think it's not worth the effort. If you get this error,
understand that it may have consequences.

ChrisA