Path: csiph.com!usenet.pasdenom.info!news.albasani.net!rt.uk.eu.org!newsfeed.xs4all.nl!newsfeed3a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
To: python-list@python.org
From: Mark Lawrence <breamoreboy@yahoo.co.uk>
Subject: Re: Can global variable be passed into Python function?
Date: Fri, 28 Feb 2014 21:23:36 +0000
References: <27ac2248-0ca3-4ba6-9d25-eaad324bc5e9@googlegroups.com> <bd36a46b-d704-4eb1-9b7d-1308d1fb6699@googlegroups.com> <mailman.7435.1393523704.18130.python-list@python.org> <5f4f5a5f-327a-4616-8235-17ee9e74c488@googlegroups.com> <530fef58$0$11113$c3e8da3@news.astraweb.com> <e24e0817-67d1-4dbd-b3ba-9250e735d261@googlegroups.com> <mailman.7453.1393562612.18130.python-list@python.org> <871tynznpd.fsf@elektro.pacujo.net> <53104798$0$11113$c3e8da3@news.astraweb.com> <mailman.7460.1393577227.18130.python-list@python.org> <87ha7jy2qs.fsf@elektro.pacujo.net> <5310b031$0$29985$c3e8da3$5496439d@news.astraweb.com> <db181305-97fe-4385-bf11-5323d4bd1160@googlegroups.com> <87iorzf4ro.fsf@elektro.pacujo.net> <mailman.7479.1393613988.18130.python-list@python.org> <877g8ff3hn.fsf@elektro.pacujo.net> <d5984405-9ad5-4514-98cf-1914a1de7bc8@googlegroups.com> <87wqgfdk6a.fsf@elektro.pacujo.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
In-Reply-To: <87wqgfdk6a.fsf@elektro.pacujo.net>
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.7480.1393622633.18130.python-list@python.org>
Lines: 63
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:67250

On 28/02/2014 21:03, Marko Rauhamaa wrote:
> "Mark H. Harris" <harrismh777@gmail.com>:
>
>> Yep, my point exactly.  nice illustration.
>
> So now, for you and me: let's compare.
>
>      if key is ast.Assign:
>          return ' '.join(dump(t) for t in node.targets)
>      elif key is ast.AugAssign:
>          # Same target and same operator.
>          return dump(node.target) + dump(node.op) + "="
>      elif key is ast.Return:
>          # A return statement is always compatible with another.
>          return "(easy)"
>      elif key is ast.Expr:
>          # Calling these never compatible is wrong. Calling them
>          # always compatible will give lots of false positives.
>          return "(maybe)"
>      else:
>          # These ones are never compatible, so return some
>          # object that's never equal to anything.
>          return float("nan")
>
> vs (my proposal):
>
>      with key from ast:
>          if Assign:
>              return ' '.join(dump(t) for t in node.targets)
>          elif AugAssign:
>              # Same target and same operator.
>              return dump(node.target) + dump(node.op) + "="
>          elif Return:
>              # A return statement is always compatible with another.
>              return "(easy)"
>          elif Expr:
>              # Calling these never compatible is wrong. Calling them
>              # always compatible will give lots of false positives.
>              return "(maybe)"
>          else:
>              # These ones are never compatible, so return some
>              # object that's never equal to anything.
>              return float("nan")
>
> Which do *you* find more readable?
>
>
> Marko
>

http://c2.com/cgi/wiki?SwitchStatementsSmell

-- 
My fellow Pythonistas, ask not what our language can do for you, ask 
what you can do for our language.

Mark Lawrence

---
This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com