Path: csiph.com!usenet.pasdenom.info!gegeweb.org!de-l.enfer-du-nord.net!feeder1.enfer-du-nord.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
From: "Prasad, Ramit" <ramit.prasad@jpmorgan.com>
To: "python-list@python.org" <python-list@python.org>
Subject: RE: Decorators not worth the effort
Thread-Topic: Decorators not worth the effort
Thread-Index: AQHNknv7gkzFT+MRnk+Cb3hCY/E2RZeKdLyw
Date: Fri, 14 Sep 2012 23:14:00 +0000
References: <XnsA0CE7D6F43F18duncanbooth@127.0.0.1> <1017333532.1009581.1347628946603.JavaMail.root@sequans.com>
In-Reply-To: <1017333532.1009581.1347628946603.JavaMail.root@sequans.com>
Accept-Language: en-US
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.727.1347664449.27098.python-list@python.org>
Lines: 28
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:29194

Jean-Michel Pichavant wrote:=0D=0A=0D=0A[snip]=0D=0A=0D=0A> Ultimately, the=
 goal is to have something like=0D=0A> =0D=0A> @timeout(2)=0D=0A> def doAct=
ion1=0D=0A> =0D=0A> @timeout(4)=0D=0A> def doAction2=0D=0A=0D=0A[snip]=0D=
=0A=0D=0A> Here's Steven example:=0D=0A> =0D=0A> # Untested!=0D=0A> def tim=
eout(t=3D15):=0D=0A>     # Decorator factory=2E Return a decorator to actua=
lly do the work=2E=0D=0A>     if FPGA:=0D=0A>         t *=3D 3=0D=0A>     d=
ef decorator(func):=0D=0A>         @functools=2Ewraps(func)=0D=0A>         =
def inner(self, timeout):=0D=0A>             self=2EsendCmd("bootMe", timeo=
ut=3Dt)=0D=0A>         return inner=0D=0A>     return decorator=0D=0A> =0D=
=0A> I can assure you, that for some python users, it's is not easy to unde=
rstand=0D=0A> what it does, this function returning a function which return=
s another=0D=0A> (wrapped) function=2E It requires some effort=2E=0D=0A> =
=0D=0A=0D=0AI think it would help if it was renamed to set_timeout=2E And I=
 would =0D=0Anot expect the Python user to need to understand how it *works=
*, just =0D=0Ato recognize what it *does* when it is used=2E I may not unde=
rstand list's =0D=0Asort method internals (beyond the use of timsort), but =
I know how to =0D=0Ause it to sort a list as I want=2E That is usually all =
I need=2E=0D=0A =0D=0A=0D=0AFor example, your colleagues just need to under=
stand that the below=0D=0Adecorator is setting a timeout for the function=
=2E=0D=0A=0D=0A@set_timeout(min=3D15)=0D=0Adef some_function():=0D=0A    ''=
'blah'''=0D=0A      <code> =0D=0A=0D=0A=0D=0AOne minor note, the style of d=
ecorator you are using loses the docstring=0D=0A(at least) of the original =
function=2E I would add the @functools=2Ewraps(func) =0D=0Adecorator inside=
 your decorator=2E=0D=0A=0D=0AThis email is confidential and subject to imp=
ortant disclaimers and=0D=0Aconditions including on offers for the purchase=
 or sale of=0D=0Asecurities, accuracy and completeness of information, viru=
ses,=0D=0Aconfidentiality, legal privilege, and legal entity disclaimers,=
=0D=0Aavailable at http://www=2Ejpmorgan=2Ecom/pages/disclosures/email=2E