Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From: Robin Becker <robin@reportlab.com>
Newsgroups: comp.lang.python
Subject: 2.7 source import in python 3.x
Date: Mon, 4 Apr 2016 11:27:25 +0100
Lines: 36
Message-ID: <mailman.7.1459765644.32530.python-list@python.org>
References: <5702418D.6080906@chamonix.reportlab.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
Precedence: list
Xref: csiph.com comp.lang.python:106429

A user points out that this code in reportlab uses the now deprecated imp module

def _fake_import(fn,name):
     if os.path.isfile(fn):
         import imp
         with open(fn,'rb') as f:
             imp.load_source(name,fn,f)

and suggests I use importlib SourceFileLoader. Is there anything wrong with this 
code (only for use in python 3.x)


def _fake_import(fn,name):
     from importlib import machinery
     m = machinery.SourceFileLoader(name,fn)
     try:
         return m.load_module(name)
     except FileNotFoundError:
         raise ImportError('file %s not found' % ascii(fn))

the newer import machinery seems particularly complex so I'm not at all sure 
this does what I intend even though it seems to work.

The original function is only used once like this

> try:
>     _fake_import(os.path.expanduser(os.path.join('~','.reportlab_mods')),'reportlab_mods')
> except (ImportError,KeyError):
>     pass

and is intended to allow per user actions in a config file when reportlab is 
imported.

-- 
Robin Becker