Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!goblin2!goblin.stu.neva.ru!newsfeed.xs4all.nl!newsfeed3a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
Sender: kwatch@gmail.com
Date: Sat, 15 Feb 2014 13:39:14 +0900
Subject: [Q] Beaker 1.6.4 not work on Python3
From: Makoto Kuwata <kwa@kuwata-lab.com>
To: python-list@python.org
Content-Type: multipart/alternative; boundary=001a113a9c022cb12204f26a81be
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.6994.1392471063.18130.python-list@python.org>
Lines: 146
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:66434

--001a113a9c022cb12204f26a81be
Content-Type: text/plain; charset=ISO-8859-1

Hi,

Does Beaker 1.6.4 work on Python3 ?
Is there anyone using Beaker on Python3?


I got the following error on Python 3.3:


  File "/opt/lang/python/3.2.2/lib/python3.2/http/cookies.py", line 486, in
__setitem__
    rval, cval = self.value_encode(value)
  File
"/opt/lang/python/3.2.2/lib/python3.2/site-packages/Beaker-1.6.4-py3.2.egg/beaker/session.py",
line 70, in value_encode
    sig = HMAC.new(self.secret, val.encode('UTF-8'), SHA1).hexdigest()
AttributeError: 'bytes' object has no attribute 'encode'


The following is a monkey patch to avoid this error,
but I'm not sure that it is correct solution.


    from beaker.crypto import hmac as HMAC, hmac_sha1 as SHA1
    from beaker.session import SignedCookie
    def value_encode(self, val):
        #sig = HMAC.new(self.secret, val.encode('UTF-8'), SHA1).hexdigest()
        sig = HMAC.new(self.secret, val, SHA1).hexdigest()
        return str(val), ("%s%s" % (sig, val))
    SignedCookie.value_encode = value_encode


And, even with monkey patching, Beaker's SessionMiddleware
doesn't save session correctly on Python3.


Please help me: I want to run Beaker 1.6.4 on Python 3.
(Pyton 3.3.3, MacOSX)

Here is my sample code (which works on Python2.7 very well!):
------------------------------------------------------
# -*- coding: utf-8 -*-

import sys
import waitress
from beaker.middleware import SessionMiddleware

def testapp(environ, start_response):
    session = environ.get('beaker.session')
    count = session.get('count', 0) + 1
    session['count'] = count
    session.save()
    content = "count=%s" % count
    #
    start_response('200 OK', [('Content-Type', 'text/plain')])
    return [content.encode('utf-8')]

config = {
    'session.type': 'cookie',
    'session.validate_key': 'mysecretstring',
}
app = SessionMiddleware(testapp, config=config)

## monkey patch for Python3
python3 = sys.version_info[0] == 3
if 0 and python3:
    from beaker.crypto import hmac as HMAC, hmac_sha1 as SHA1
    from beaker.session import SignedCookie
    def value_encode(self, val):
        #sig = HMAC.new(self.secret, val.encode('UTF-8'), SHA1).hexdigest()
        sig = HMAC.new(self.secret, val, SHA1).hexdigest()
        return str(val), ("%s%s" % (sig, val))
    SignedCookie.value_encode = value_encode
## ----

waitress.serve(app, port=8080)
------------------------------------------------------

--
regards,
makoto kuwata

--001a113a9c022cb12204f26a81be
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div><br></div><div>Does Beaker 1.6.4 work o=
n Python3 ?</div><div>Is there anyone using Beaker on Python3?</div><div><b=
r></div><div><br></div><div>I got the following error on Python 3.3:</div>
<div><br></div><div><br></div><div>=A0 File &quot;/opt/lang/python/3.2.2/li=
b/python3.2/http/cookies.py&quot;, line 486, in __setitem__</div><div>=A0 =
=A0 rval, cval =3D self.value_encode(value)</div><div>=A0 File &quot;/opt/l=
ang/python/3.2.2/lib/python3.2/site-packages/Beaker-1.6.4-py3.2.egg/beaker/=
session.py&quot;, line 70, in value_encode</div>
<div>=A0 =A0 sig =3D HMAC.new(self.secret, val.encode(&#39;UTF-8&#39;), SHA=
1).hexdigest()</div><div>AttributeError: &#39;bytes&#39; object has no attr=
ibute &#39;encode&#39;</div><div><br></div><div><br></div><div>The followin=
g is a monkey patch to avoid this error,</div>
<div>but I&#39;m not sure that it is correct solution.</div><div><br></div>=
<div><br></div><div>=A0 =A0 from beaker.crypto import hmac as HMAC, hmac_sh=
a1 as SHA1</div><div>=A0 =A0 from beaker.session import SignedCookie</div><=
div>
=A0 =A0 def value_encode(self, val):</div><div>=A0 =A0 =A0 =A0 #sig =3D HMA=
C.new(self.secret, val.encode(&#39;UTF-8&#39;), SHA1).hexdigest()</div><div=
>=A0 =A0 =A0 =A0 sig =3D HMAC.new(self.secret, val, SHA1).hexdigest()</div>=
<div>=A0 =A0 =A0 =A0 return str(val), (&quot;%s%s&quot; % (sig, val))</div>
<div>=A0 =A0 SignedCookie.value_encode =3D value_encode</div><div><br></div=
><div><br></div><div>And, even with monkey patching, Beaker&#39;s SessionMi=
ddleware</div><div>doesn&#39;t save session correctly on Python3.</div><div=
><br>
</div><div><br></div><div>Please help me: I want to run Beaker 1.6.4 on Pyt=
hon 3.</div><div>(Pyton 3.3.3, MacOSX)</div><div><br></div><div>Here is my =
sample code (which works on Python2.7 very well!):</div><div>--------------=
----------------------------------------</div>
<div># -*- coding: utf-8 -*-</div><div><br></div><div>import sys</div><div>=
import waitress</div><div>from beaker.middleware import SessionMiddleware</=
div><div><br></div><div>def testapp(environ, start_response):</div><div>
=A0 =A0 session =3D environ.get(&#39;beaker.session&#39;)</div><div>=A0 =A0=
 count =3D session.get(&#39;count&#39;, 0) + 1</div><div>=A0 =A0 session[&#=
39;count&#39;] =3D count</div><div>=A0 =A0 session.save()</div><div>=A0 =A0=
 content =3D &quot;count=3D%s&quot; % count</div>
<div>=A0 =A0 #</div><div>=A0 =A0 start_response(&#39;200 OK&#39;, [(&#39;Co=
ntent-Type&#39;, &#39;text/plain&#39;)])</div><div>=A0 =A0 return [content.=
encode(&#39;utf-8&#39;)]</div><div><br></div><div>config =3D {</div><div>=
=A0 =A0 &#39;session.type&#39;: &#39;cookie&#39;,</div>
<div>=A0 =A0 &#39;session.validate_key&#39;: &#39;mysecretstring&#39;,</div=
><div>}</div><div>app =3D SessionMiddleware(testapp, config=3Dconfig)</div>=
<div><br></div><div>## monkey patch for Python3</div><div>python3 =3D sys.v=
ersion_info[0] =3D=3D 3</div>
<div>if 0 and python3:</div><div>=A0 =A0 from beaker.crypto import hmac as =
HMAC, hmac_sha1 as SHA1</div><div>=A0 =A0 from beaker.session import Signed=
Cookie</div><div>=A0 =A0 def value_encode(self, val):</div><div>=A0 =A0 =A0=
 =A0 #sig =3D HMAC.new(self.secret, val.encode(&#39;UTF-8&#39;), SHA1).hexd=
igest()</div>
<div>=A0 =A0 =A0 =A0 sig =3D HMAC.new(self.secret, val, SHA1).hexdigest()</=
div><div>=A0 =A0 =A0 =A0 return str(val), (&quot;%s%s&quot; % (sig, val))</=
div><div>=A0 =A0 SignedCookie.value_encode =3D value_encode</div><div>## --=
--</div><div><br></div>
<div>waitress.serve(app, port=3D8080)</div><div>---------------------------=
---------------------------</div><div><br></div><div>--</div><div>regards,<=
/div><div>makoto kuwata</div><div><br></div></div>

--001a113a9c022cb12204f26a81be--