Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!xlned.com!feeder5.xlned.com!newsfeed.xs4all.nl!newsfeed3a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.031 X-Spam-Evidence: '*H*': 0.94; '*S*': 0.00; 'from:addr:ethan': 0.09; 'from:addr:stoneleaf.us': 0.09; 'from:name:ethan furman': 0.09; 'message-id:@stoneleaf.us': 0.09; '~ethan~': 0.09; 'python': 0.11; 'all?': 0.16; 'personally,': 0.16; 'roy': 0.16; 'subject:bit': 0.16; 'sure.': 0.16; 'wrote:': 0.18; 'replacing': 0.19; 'seems': 0.21; 'tests': 0.22; 'header:User-Agent:1': 0.23; "haven't": 0.24; 'second': 0.26; 'header:In-Reply-To:1': 0.27; 'am,': 0.29; 'fastest': 0.30; "i'm": 0.30; "skip:' 10": 0.31; 'clever': 0.31; 'index,': 0.31; 'run': 0.32; 'but': 0.35; 'there': 0.35; 'doing': 0.36; 'method': 0.36; 'charset:us-ascii': 0.36; 'unit': 0.37; 'too': 0.37; 'to:addr:python-list': 0.38; 'to:addr:python.org': 0.39; 'easy': 0.60; 'catch': 0.60; 'received:173': 0.61; 'further': 0.61; 'first': 0.61; 'email addr:gmail.com': 0.63; 'received:69.56': 0.68; 'skip:r 30': 0.69; 'milliseconds': 0.84; 'otten': 0.84; 'received:gateway02.websitewelcome.com': 0.91 Date: Thu, 13 Feb 2014 11:59:10 -0800 From: Ethan Furman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: python-list@python.org Subject: Re: A curious bit of code... References: <4cc09129-43ee-4205-a24c-03f92b594abc@googlegroups.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3304.hostgator.com X-AntiAbuse: Original Domain - python.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stoneleaf.us X-BWhitelist: no X-Source-IP: 173.12.184.233 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([173.12.184.233]) [173.12.184.233]:33862 X-Source-Auth: ethan+stoneleaf.us X-Email-Count: 4 X-Source-Cap: dG9idWs7dG9idWs7Z2F0b3IzMzA0Lmhvc3RnYXRvci5jb20= X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 52 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1392321537 news.xs4all.nl 2852 [2001:888:2000:d::a6]:39091 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:66225 On 02/13/2014 11:43 AM, Peter Otten wrote: > forman.simon@gmail.com wrote: > >> I ran across this and I thought there must be a better way of doing it, >> but then after further consideration I wasn't so sure. >> >> if key[:1] + key[-1:] == '<>': ... >> >> >> Some possibilities that occurred to me: >> >> if key.startswith('<') and key.endswith('>'): ... >> >> and: >> >> if (key[:1], key[-1:]) == ('<', '>'): ... >> >> >> I haven't run these through a profiler yet, but it seems like the original >> might be the fastest after all? > > $ python -m timeit -s 's = ""' 's[:1]+s[-1:] == "<>"' > 1000000 loops, best of 3: 0.37 usec per loop > > $ python -m timeit -s 's = ""' 's[:1] == "<" and s[-1:] == ">"' > 1000000 loops, best of 3: 0.329 usec per loop > > $ python -m timeit -s 's = ""' 's.startswith("<") and > s.endswith(">")' > 1000000 loops, best of 3: 0.713 usec per loop > > The first is too clever for my taste. > > The second is fast and easy to understand. It might attract "improvements" > replacing the slice with an index, but I trust you will catch that with your > unit tests ;) > > Personally, I'm willing to spend the few extra milliseconds and use the > foolproof third. For completeness: # the slowest method from Peter $ python -m timeit -s 's = ""' 's.startswith("<") and s.endswith(">")' 1000000 loops, best of 3: 0.309 usec per loop # the re method from Roy $ python -m timeit -s "import re;pattern=re.compile(r'^<.*>$');s = ''" "pattern.match(s)" 1000000 loops, best of 3: 0.466 usec per loop -- ~Ethan~