Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From: Michael Selik <michael.selik@gmail.com>
Newsgroups: comp.lang.python
Subject: Re: Design: Idiom for classes and methods that are customizable by the user?
Date: Fri, 13 May 2016 20:33:11 +0000
Lines: 31
Message-ID: <mailman.647.1463171609.32212.python-list@python.org>
References: <5734ECDF.7070006@gmx.de> <mailman.617.1463087060.32212.python-list@python.org> <dplassFelugU1@mid.individual.net> <CAGgTfkPeqybAeqXLq8FHyRSb+d8KLemvxLrk8i3PfbWdwV4rBA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <dplassFelugU1@mid.individual.net>
Precedence: list
Xref: csiph.com comp.lang.python:108619

On Fri, May 13, 2016 at 2:41 AM Gregory Ewing <greg.ewing@canterbury.ac.nz>
wrote:

> Dirk B=C3=A4chle wrote:
> > I'm currently following the "Factory" pattern (more or less) as I know
> > it from C++ and similar languages.
>
> This statement sets off alarm bells for me. If you're using some
> design pattern in Python just because you learned to do it that
> way in C++/Java/whatever, you're probably making it more
> complicated than it needs to be.
>

I share Greg's trepidation when I hear a phrase like that, but the general
idea of a registry of classes or functions and then picking the right one
based on string input is fine.

How would the API work for custom Taskmasters? It's not so great to require
that the user must explicitly ``add`` their derived class after defining
it. Perhaps that add function could be a decorator?

def register(key):
    def decorator(cls):
        if not issubclass(cls, Taskmaster):
            raise TypeError('You fool!')
        registry[key] =3D cls
    return decorator

@register('noclean')
class NoCleanTaskMaster(TaskMaster):
    "Looks clean enough, why worry?"