Path: csiph.com!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder1.hal-mli.net!newsfeed.xs4all.nl!newsfeed2a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <b21f1406-a294-4e70-b039-09024e7928e0@googlegroups.com>
References: <e3b195f8-5a17-4536-9926-2b2ab193719c@googlegroups.com> <mailman.6376.1391489248.18130.python-list@python.org> <b21f1406-a294-4e70-b039-09024e7928e0@googlegroups.com>
Date: Tue, 4 Feb 2014 16:18:11 +1100
Subject: Re: Logging data from Arduino using PySerial
From: Chris Angelico <rosuav@gmail.com>
Cc: "python-list@python.org" <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.6378.1391491099.18130.python-list@python.org>
Lines: 55
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:65405

On Tue, Feb 4, 2014 at 3:57 PM, Thomas <t.tchorzewski@gmail.com> wrote:
> Wow...Thanks Chris! I really appreciate your suggestions (including the s=
tylistic ones). I'll definitely be revising my code as soon as I find the t=
ime. As far as profiling goes, I've used timeit in the past but it's quite =
a pain going through any program block by block. I wish there were a progra=
m in which you could just toss in a script and it would spit out the bottle=
necks in your code (with suggested performance improvements perhaps)...
>

Well, timeit is good for microbenchmarking. (How useful
microbenchmarking itself is, now, that's a separate question.) For
anything where you can "feel" the program's time by human, it's easy
enough to use the time.time() function.

Add a little helper like this (untested):

last_time =3D time.time()
def tt(desc):
    global last_time
    cur_time=3Dtime.time()
    print("%s: %f"%(desc,cur_time-last_time))
    last_time=3Dcur_time


Then put this all through your code:

....

    # Calculating the length of data to collect based on the
    # sample time and simulation time (set by user)
    max_length =3D sim_time/sample_time

    tt("Init")

    # Collecting the data from the serial port
    while True:
        data_log.append(connection.readline())
        if len(data_log) > max_length - 1:
            break

    tt("Serial")

...

etc etc. Give it a short description saying what's just happened
(because it'll give the time since the previous timepoint), and then
just eyeball the results to see where the biggest numbers are. If you
do it right, you'll find a whole pile of sections with tiny numbers,
which you can easily ignore, and just a handful that even register.
Then you dig into those sections and see where the slowness is.

Be careful, though. You can easily waste hundreds of expensive dev
hours trying to track down an insignificant time delay. :)

ChrisA