Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From: "Frank Millman" <frank@chagford.com>
Newsgroups: comp.lang.python
Subject: Re: asyncio - how to stop background task cleanly
Date: Sun, 7 Feb 2016 09:10:36 +0200
Lines: 78
Message-ID: <mailman.62.1454829054.2317.python-list@python.org>
References: <mailman.32.1454746369.2317.python-list@python.org> <87lh6ys052.fsf@elektro.pacujo.net> <mailman.41.1454767329.2317.python-list@python.org> <87fux5svhk.fsf@elektro.pacujo.net> <8737t5shhp.fsf@elektro.pacujo.net> <n96kjr$mvl$1@ger.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response
Content-Transfer-Encoding: 7bit
In-Reply-To: <n96kjr$mvl$1@ger.gmane.org>
Importance: Normal
Precedence: list
Xref: csiph.com comp.lang.python:102612

"Frank Millman"  wrote in message news:n96kjr$mvl$1@ger.gmane.org...
>
> "Marko Rauhamaa"  wrote in message 
> news:8737t5shhp.fsf@elektro.pacujo.net...
>
> > Actually, cancellation is specially supported in asyncio (<URL:
> > https://docs.python.org/3/library/asyncio-task.html#asyncio.Task.cancel>)
> > so this should do:
> >
> >     async def background_task():
> >         while True:
> >             await perform_task()
> >             await asyncio.sleep(10)
> >
>
> That's exactly what I needed - thanks, Marko
>
>     async def background_task()
>         try:
>             while True:
>                 await perform_task()
>                 await asyncio.sleep(10)
>         except asyncio.CancelledError:
>                 await perform_cleanup()
>
> At startup -
>
>     task = asyncio.ensure_future(background_task())
>
> At shutdown -
>
>     task.cancel()
>     await asyncio.wait([task])
>
> Works perfectly - thanks again.
>

Alas, I spoke too soon.

I tried to simulate what would happen if the background task was busy with a 
task when it was cancelled -

    async def background_task()
        try:
            while True:
                print('start')
                time.sleep(2)
                print('done')
                await asyncio.sleep(10)
        except asyncio.CancelledError:
                print('cleanup')
        print('DONE')

If I cancel after a pair of 'start/done' appear, the background task is in 
the 'asyncio.sleep' stage. The words 'cleanup' and 'DONE' appear instantly, 
and the program halts.

If I cancel after 'start', but before 'done', the background task is 
executing a task. There is a delay of up to 2 seconds, then the words 
'done',  'cleanup', and 'DONE' appear, but the program hangs. If I press 
Ctrl+C, I get a traceback from the threading module -

    line 1288, in _shutdown
        t.join()
    line 1054, in join
        self._wait_for_tstate_lock()
    line 1070, in _wait_for_tstate_lock
KeyboardInterrupt

So it is waiting for join() to complete. I will continue investigating, but 
will report it here to see if anyone can come up with an 
explanation/solution.

Thanks

Frank