Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed4.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Date: Tue, 20 Nov 2012 09:46:28 -0500
From: Dave Angel <d@davea.name>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121011 Thunderbird/16.0.1
MIME-Version: 1.0
To: inshu chauhan <insideshoes@gmail.com>
Subject: Re: Index Error
References: <CAFqGZRHSZ2QTqw=_iZWCWVJXVoxEZvHkTEmb-QeohRer2hjj7w@mail.gmail.com> <50AB8FB1.2030208@davea.name> <CAFqGZRG3eu21YxBwcJ=vb-ZSgG8DszEhjkcU1ppAKpUPBO_5Yg@mail.gmail.com>
In-Reply-To: <CAFqGZRG3eu21YxBwcJ=vb-ZSgG8DszEhjkcU1ppAKpUPBO_5Yg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "python-list@python.org" <python-list@python.org>
Precedence: list
Reply-To: d@davea.name
Newsgroups: comp.lang.python
Message-ID: <mailman.59.1353422809.29569.python-list@python.org>
Lines: 81
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:33622

On 11/20/2012 09:26 AM, inshu chauhan wrote:
>> def GenerateRing(x,y, N): Generates square rings around a point in data
>>> which has 300 columns(x) and 3000 rows(y)
>>>     indices = []
>>>     for i in xrange(-N, N):
>>>         indices.append((x+i, y-N))
>>>         indices.append((x+N, y+i))
>>>         indices.append((x-i, y+N))
>>>         indices.append((x-N, y-i))
>>>     return indices
>>>
>> Is it possible that N is greater than either x or y ?  Are negative
>> subscripts permissible?
>>
>> You should consider doing the clipping logic in this function, perhaps
>> by passing xlimit and ylimit in as arguments.>
>>
> 
> 
> Yes N cannot be greater than x and y and it cant be negative too...
> 
>>      I need help in this part as I am unable to device a method in
>> which if the
>> points are out of index,it should stop and
>>                         if idx[0] >= 300 and idx[1] >= 3000:           go
>> to next centre and start generating rings from there.. and again if the
>> index is out of range .. this should repeat
> 
> This is where you're trying to clip the values that may be outside of
>> the total matrix.
>>
> 
> Yes I am trying to clip the values here but its not working actually , I
> mean not at all working
> 

So did you read the following paragraphs?  You should not be using "and"
in that expression.

>>
>> You do not want "and" in that expression.  The way you've coded it,
>> it'll only skip items in which both indices are out of range.  Change it to
>>                   if idx[0] >= data.width or idx[1] >= data.height:
>>
>> and depending on your answer to my earlier query, you may want to also
>> check if either subscript is negative.
>>
>>>                             continue
>>>                         else :
>>>                             point = data[idx[0], idx[1]]
>>>                             if point == (0.0, 0.0, 0.0 ):
>>>                                 print point
>>>                                 continue
>>>                             else:
>>>                                 dist = distance(centre, point)
>>>                                 print dist
>>>                                 if  dist < radius :               and
>> rings
>>> should be added only when this condition is satisfied
>>>                                     print point
>>>                                     points.append(point)
>>>                                     change = True
>>>                                     print change
>>>
>>>
>>>                         break
>>
>> Why do you want to terminate the loop after only iteration?
>>
> 
> I dint get your question ??
> 

You have a break there.  What's it for?  It'll make sure you only
process one of the idx values from new_indices.  i doubt that's what you
intended.


-- 

DaveA