Path: csiph.com!usenet.pasdenom.info!dedibox.gegeweb.org!gegeweb.eu!nntpfeed.proxad.net!proxad.net!feeder1-2.proxad.net!usenet-fr.net!nerim.net!novso.com!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <lb62ik$29b$1@ger.gmane.org>
References: <22d58d76-f2c2-4a1d-8049-3409ac4665d3@googlegroups.com> <mailman.5207.1389223748.18130.python-list@python.org> <9202d352-e065-4f2b-a9e0-e29ce5c68df6@googlegroups.com> <CAPTjJmpb6yr-VpWypbJQn0a=pNjvNV2CchVBZaK+v_5JoSQOBg@mail.gmail.com> <lb62ik$29b$1@ger.gmane.org>
Date: Thu, 16 Jan 2014 01:07:51 +1100
Subject: Re: Learning python networking
From: Chris Angelico <rosuav@gmail.com>
Cc: "python-list@python.org" <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.5514.1389795187.18130.python-list@python.org>
Lines: 42
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:63987

On Thu, Jan 16, 2014 at 12:31 AM, Frank Millman <frank@chagford.com> wrote:
> I think you may have omitted a line there -
>
> def gets():
>     while '\n' not in buffer:
>         data = sock.recv(1024)
>         if not data:
>             # Client is disconnected, handle it gracefully
>             return None # or some other sentinel
> #-->
>         buffer = buffer + data
> #-->
>     line, buffer = buffer.split(b'\n',1)
>     return line.decode().replace('\r', '')

Yes, indeed I did, thanks. Apart from using augmented assignment,
that's exactly what I would have put there, if I'd actually taken a
moment to test the code.

> Also, as I am looking at it, I notice that the second line should say -
>
>     while b'\n' not in buffer:

Right again. Fortunately, Py3 would catch that one with a TypeError.
See? This is why you should use Py3. :)

> I feel a bit guilty nitpicking, as you have provided a wonderfully
> comprehensive answer, but I wanted to make sure the OP did not get confused.

No no, nitpicking is exactly what ensures that the end result is
correct. If I got offended at you correcting my code, it would imply
that I think myself perfect (or at least, that I consider you to be
utterly incapable of noticing my errors), which is provably false :)
One of the mind-set changes that I had to introduce at work was that
people don't own code, the repository does - if you see an improvement
to something I wrote, or I see an improvement to something you wrote,
they're improvements to be committed, not turf wars to be battled
over.

Especially on something like this, please *do* catch other people's mistakes :)

ChrisA