Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!selfless.tophat.at!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Date: Thu, 30 Jun 2011 20:40:12 -0500
From: Andrew Berg <bahamutzero8825@gmail.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 ThunderBrowse/3.3.5
MIME-Version: 1.0
To: "comp.lang.python" <python-list@python.org>
Subject: Re: Trying to chain processes together on a pipeline
References: <4E096D3B.3080300@gmail.com> <iubshf$dus$1@dough.gmane.org>
In-Reply-To: <iubshf$dus$1@dough.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.532.1309484420.1164.python-list@python.org>
Lines: 70
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:8617

Okay, so I've refactored those except WindowsError blocks into calls to
a function and fixed the os.devnull bug, but I still can't get the
triple chain working. I added calls to ffmpeg_proc.stdout.close() and
sox_proc.stdout.close(), but I really am not sure where to put them. The
following code works if SoX isn't part of the chain (that is, if vol ==
1), but not otherwise (the Nero encoder says "truncation error" after it
finishes; the same error I get if omit the close() calls):
> while True:
>     if queue[position].audio:
>         if queue[position].vol != 1:
>             queue[position].ffmpeg_cmd = [
>             queue[position].ffmpeg_exe,
>             '-i', queue[position].ifile,
>             '-f', 'sox', '-'
>             ]
>             queue[position].sox_cmd = [
>             queue[position].sox_exe,
>             '-t', 'sox', '-',
>             '-t', 'wav', '-',
>             'vol', str(queue[position].vol)
>             ]
>         else:
>             queue[position].ffmpeg_cmd = [
>             queue[position].ffmpeg_exe,
>             '-i', queue[position].ifile,
>             '-f', 'wav', '-'
>             ]
>         queue[position].nero_aac_cmd = [
>         queue[position].nero_aac_exe,
>         '-ignorelength',
>         '-q', str(queue[position].aac_quality),
>         '-if', '-',
>         '-of', queue[position].outdir + queue[position].prefix + '.m4a'
>         ]
>     print(queue[position].ffmpeg_cmd)
>     print(queue[position].sox_cmd)
>     print(queue[position].nero_aac_cmd)
>     try:
>         ffmpeg_proc = subprocess.Popen(queue[position].ffmpeg_cmd,
> stdout=subprocess.PIPE, stderr=open(os.devnull, 'w'))
>     except WindowsError as exc:
>         log_windows_error(exc, queue[position].ffmpeg_cmd, 'critical')
>         break
>     if queue[position].vol != 1:
>         try:
>             sox_proc = subprocess.Popen(queue[position].sox_cmd,
> stdin=ffmpeg_proc.stdout, stdout=subprocess.PIPE,
> stderr=open(os.devnull, 'w'))
>             wav_pipe = sox_proc.stdout
>         except WindowsError as exc:
>             log_windows_error(exc, queue[position].sox_cmd, 'critical')
>             break
>     else:
>         wav_pipe = ffmpeg_proc.stdout
>     try:
>         nero_aac_proc = subprocess.Popen(queue[position].nero_aac_cmd,
> stdin=wav_pipe)
>     except WindowsError as exc:
>         log_windows_error(exc, queue[position].nero_aac_cmd, 'critical')
>         break
>     finally:
>         ffmpeg_proc.stdout.close()
>         if queue[position].vol != 1:
>             sox_proc.stdout.close()
>     ffmpeg_proc.wait()
>     if queue[position].vol != 1:
>         sox_proc.wait()
>     nero_aac_proc.wait()
>     break