Path: csiph.com!usenet.pasdenom.info!news.albasani.net!news.stack.nl!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.002 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'python,': 0.02; 'feedback.': 0.04; 'context': 0.07; 'sized': 0.07; 'welcome.': 0.07; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'sentence': 0.09; 'typed': 0.09; 'python': 0.11; 'finney': 0.16; 'readable': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'discussion': 0.18; 'later': 0.20; 'coding': 0.22; 'header :User-Agent:1': 0.23; "i've": 0.25; 'script': 0.25; 'header:X -Complaints-To:1': 0.27; 'court': 0.30; "i'm": 0.30; 'code': 0.31; 'wright': 0.31; 'writes:': 0.31; 'actual': 0.34; 'but': 0.35; 'there': 0.35; 'hi,': 0.36; 'effort': 0.37; 'easily': 0.37; 'ben': 0.38; 'ends': 0.38; 'to:addr:python-list': 0.38; 'rather': 0.38; 'sure': 0.39; 'to:addr:python.org': 0.39; 'enough': 0.39; 'received:org': 0.40; 'email addr:gmail.com': 0.63; 'myself': 0.63; 'our': 0.64; 'teaching': 0.64; 'readers': 0.68; 'bells': 0.84; 'curl': 0.84; 'girlfriend': 0.84; 'responses': 0.93 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Ben Finney Subject: Re: Constructive Criticism Date: Thu, 09 Jan 2014 17:09:17 +1100 References: <8574fa07-af12-4e62-9cbc-3bd00802b6e2@googlegroups.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Gmane-NNTP-Posting-Host: rasputin.madmonks.org X-Public-Key-ID: 0xAC128405 X-Public-Key-Fingerprint: 517C F14B B2F3 98B0 CB35 4855 B8B2 4C06 AC12 8405 X-Public-Key-URL: http://www.benfinney.id.au/contact/bfinney-gpg.asc X-Post-From: Ben Finney User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) Cancel-Lock: sha1:7BRfJtyRvLKIQYjyHMGi2u+6isI= X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 29 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1389247771 news.xs4all.nl 2926 [2001:888:2000:d::a6]:53749 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:63573 jeremiahvalerio123@gmail.com writes: > Hi, hows it going I've been self teaching myself python Welcome to Python, and to this discussion forum! > and i typed up this small script now i know its not the best the > coding is not the best but i would like to know of ways to make a > small script like this better so all constructive critisim is Welcome. Some constructive criticism: * Please make an effort to write readable English here. A run-on sentence like the above makes it seem as though you don't care enough for our help to make your message easily readable. * Please paste the code in your actual message, rather than directing to an ephemeral website. This is so that the discussion will always have the code for context when later readers view it. Once you re-post your program and describe its purpose, I'm sure there will be some responses giving feedback. -- \ “My girlfriend has a queen sized bed; I have a court jester | `\ sized bed. It's red and green and has bells on it, and the ends | _o__) curl up.” —Steven Wright | Ben Finney