Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail From: Stephen Hansen Newsgroups: comp.lang.python Subject: Re: pylint woes Date: Sun, 08 May 2016 08:15:36 -0700 Lines: 19 Message-ID: References: <1462673665.770286.601202553.071593AE@webmail.messagingengine.com> <1462720536.896455.601493505.776FAC7D@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: news.uni-berlin.de sow4TS2oz1rzmanQUKqykww0JCFEEfRNGxqFfC7xreEg== Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.007 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'happens.': 0.09; 'received:internal': 0.09; 'commit': 0.15; 'dfs': 0.16; 'message- id:@webmail.messagingengine.com': 0.16; 'received:10.202': 0.16; 'received:10.202.2': 0.16; 'received:66.111': 0.16; 'received:66.111.4': 0.16; 'received:io': 0.16; 'received:messagingengine.com': 0.16; 'received:psf.io': 0.16; 'wrote:': 0.16; '(in': 0.18; 'stephen': 0.22; 'am,': 0.23; 'decide': 0.23; 'header:In-Reply-To:1': 0.24; 'chris': 0.26; 'error': 0.27; 'correct': 0.28; 'knows': 0.32; 'point': 0.33; 'usually': 0.33; 'something': 0.35; 'should': 0.36; 'there': 0.36; 'data.': 0.36; 'to:addr:python-list': 0.36; 'subject:: ': 0.37; 'received:10': 0.37; 'received:66': 0.38; 'or,': 0.38; 'data': 0.39; 'does': 0.39; "didn't": 0.39; 'to:addr:python.org': 0.40; 'header:Message-Id:1': 0.61; 'else.': 0.66 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=ixokai.io; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=EFlxiRBqN66nEATmV8+cK2qY9MY=; b=DEIdYL X/ROLHM+UaO1I+79SPjiY8g8acgGQkcSkd1OEvXSEtw69IqOeRO2wF/xPWcChtHX sPPfx1AqM9iE3LBZ6BrWTXctCYQkG3Xeddyu2xF/lMMjUacAu6BuLuImr40jCNmC xfkUqzDkVN3yRC7CH3S6NPO9lELy7YgIlblqE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=EFlxiRBqN66nEAT mV8+cK2qY9MY=; b=fCagVsoIfILlc80azSdTI3wmPBPOuJeeAJvUPXjh7xys8bz 9ncptR37zrtyd+gnnDCNAZutAPnZmLkDc1QmHTsn9uZyYnKSisqPDNr2r6+MYFx7 2Udh/qFCYE2tpjhcXebe15gcykbsprorKOipdIbqzihPb1LQ3kqmF3W+Wujc= X-Sasl-Enc: Q/ksltx/SOOr+qwcZj6UHxbkEw4qIeW2sIOqfpNvJy64 1462720536 X-Mailer: MessagingEngine.com Webmail Interface - ajax-140377c4 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <1462720536.896455.601493505.776FAC7D@webmail.messagingengine.com> X-Mailman-Original-References: <1462673665.770286.601202553.071593AE@webmail.messagingengine.com> Xref: csiph.com comp.lang.python:108361 On Sun, May 8, 2016, at 08:06 AM, DFS wrote: > On 5/8/2016 10:36 AM, Chris Angelico wrote: > > ... and then you just commit???!? > > > > That's what commit() does. > I assure you, he knows what commit does :) The point is, you don't usually commit after an error happens. You rollback. Or correct the data. Since the data didn't go in, there should (in theory) be nothing TO commit if an error happens. Or, there should be partial data in that needs a rollback before you decide to do something else. -- Stephen Hansen m e @ i x o k a i . i o