Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From: Ian Kelly <ian.g.kelly@gmail.com>
Newsgroups: comp.lang.python
Subject: Re: for / while else doesn't make sense
Date: Mon, 6 Jun 2016 22:35:33 -0600
Lines: 76
Message-ID: <mailman.50.1465274181.2306.python-list@python.org>
References: <CAHJ7fxhOeKFbu3=Jso=wgpBnH9Opr_J_6SHLDO+KtAqVFeGHnA@mail.gmail.com> <mailman.36.1463676220.27390.python-list@python.org> <7d453116-c02a-4211-836e-518f571c29a3@googlegroups.com> <niq3p5$ahb$1@dont-email.me> <4aafb237-4c41-4c0f-98ec-f71841c36bc1@googlegroups.com> <nis93t$v2m$1@dont-email.me> <48de4319-7c8a-419a-978c-3cff46f3490a@googlegroups.com> <57524448$0$1615$c3e8da3$5496439d@news.astraweb.com> <12226874-a705-47b1-859c-e9bed59ac6bb@googlegroups.com> <6c3b3d2e-bfc0-4c0e-ab81-55ec672f06c9@googlegroups.com> <ac1c9579-6113-4647-bbab-c63a863378ef@googlegroups.com> <7eb86c69-e0c5-4a4e-b35e-d8404bbebf9f@googlegroups.com> <878tyj97zo.fsf@elektro.pacujo.net> <6fde6944-918a-443e-b44f-0c7a69604a44@googlegroups.com> <CALwzid=9i=boJidaoZp7DHJ6-zd34qX65D1EBJoaso3B6Ro1yA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <6fde6944-918a-443e-b44f-0c7a69604a44@googlegroups.com>
Precedence: list
Xref: csiph.com comp.lang.python:109603

On Mon, Jun 6, 2016 at 6:51 PM, Lawrence D=E2=80=99Oliveiro
<lawrencedo99@gmail.com> wrote:
> On Sunday, June 5, 2016 at 11:43:20 PM UTC+12, Marko Rauhamaa wrote:
>> I often experiment with different loop constructs to find the one most
>> pleasing to the eye. Working directly off iterators is quite rare but a
>> while-vs-for consideration is frequent. Also, should the stepping part
>> be in the beginning, middle or end of the loop body?
>
> It is nice to have a common, versatile looping form which can be arranged=
 in different ways to suit the problem at hand. That=E2=80=99s why I like t=
he C-style for-statement.
>
> Here=E2=80=99s another example <https://github.com/ldo/ipy_magics/blob/ma=
ster/rman_magic.py>, for the consideration of those who don=E2=80=99t seem =
too familiar with looping:

A 500-line function? Yikes, what an eyesore. When you have to include
#end comments in order to visually match things up, that should be a
smell that your code is excessively complex. It took me a lot of
scrolling up and down just to figure out what the scopes of the
variables were.

>     while True :
>         while True :
>             line =3D next(input_line, None)
>             if line !=3D None :
>                 if len(include_stack) =3D=3D 0 :
>                     linenr +=3D 1
>                 #end if
>                 break
>             #end if
>             if len(include_stack) =3D=3D 0 :
>                 break
>             input_line =3D include_stack.pop()
>         #end while
>         if line =3D=3D None or ... line contains something special ... :
>             ...
>             if line =3D=3D None :
>                 break
>             ... process special line ...
>             ... replace with None to indicate it=E2=80=99s been processed=
 ...
>         #end if
>         if line !=3D None :
>             ... process regular line ...
>         #end if
>     #end while

    def generate_lines():
        nonlocal input_line
        while True:
            try:
                # Note input_line appears to be an iterator, not a string
                # as suggested by the name.
                yield next(input_line)
            except StopIteration:
                if include_stack:
                    input_line =3D include_stack.pop()
                else:
                    return

    for line in generate_lines():
        if not include_stack:
            linenr +=3D 1
        if ... line contains something special ...:
            ... process special line ...
        else:
            ... process regular line ...

Much simpler than the nested while loop hell above, and not a single
break needed (if you don't count the return, that is; in any case each
loop has a single exit point). I'd be tempted to refactor input_line
and include_stack into some sort of input context class and make
generate_lines a method of the class in order to avoid having those
variables be (effectively) global, but my goal was to keep this as
close to the original in design as possible.