Path: csiph.com!news.mixmin.net!newsreader4.netcologne.de!news.netcologne.de!fu-berlin.de!uni-berlin.de!not-for-mail From: Antoon Pardon Newsgroups: comp.lang.python Subject: Re: How to parameterize unittests Date: Fri, 15 Apr 2016 10:20:18 +0200 Lines: 35 Message-ID: References: <570FA466.20003@rece.vub.ac.be> <570fb1a3$0$1609$c3e8da3$5496439d@news.astraweb.com> <57108FAC.3020105@rece.vub.ac.be> <5710A442.8000906@rece.vub.ac.be> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: news.uni-berlin.de Q7Yzt+Fl+P6aoaJv5vWQbw6ClI3rRu42yYPK41dmEoog== Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'received:134': 0.05; 'lines.': 0.07; 'rewrite': 0.07; 'tests,': 0.07; 'unittest': 0.07; 'cc:addr:python-list': 0.09; 'subject:How': 0.09; 'subclass': 0.09; 'def': 0.13; '2016': 0.16; 'instantiate': 0.16; 'paste.': 0.16; 'received:ac.be': 0.16; 'received:io': 0.16; 'received:psf.io': 0.16; 'wrote:': 0.16; 'tests.': 0.18; 'tree': 0.18; 'tests': 0.18; 'thanks.': 0.18; '>>>': 0.20; 'cc:2**0': 0.20; 'cc:addr:python.org': 0.20; 'am,': 0.23; 'second': 0.24; 'written': 0.24; 'header:In-Reply-To:1': 0.24; 'header:User- Agent:1': 0.26; 'chris': 0.26; 'fri,': 0.27; 'module.': 0.27; 'see,': 0.27; "skip:' 10": 0.28; '15,': 0.30; 'received:be': 0.30; 'run': 0.33; 'class': 0.33; 'largely': 0.33; 'steven': 0.33; 'instance': 0.35; 'but': 0.36; 'pm,': 0.36; 'subject:: ': 0.37; 'two': 0.37; 'reuse': 0.66; 'cut': 0.67; 'directly.': 0.76; 'angelico:': 0.84; "d'aprano:": 0.84; 'pardon': 0.84; 'schreef': 0.84 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQJAIOjEFeGuA9G/2dsb2JhbABehFQBM7wvhg4CggoBAQEBAQFmhGkBAQQjVQEQCw4KAgIFFgsCAgkDAgECAUUGDQYCAoglsB+NSIRQAQEBAQEFAQEBARx8hSWES4c/glYBBJgMgVWMOYkthWSPKWKDaWoBiUUBAQE User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <5710A442.8000906@rece.vub.ac.be> X-Mailman-Original-References: <570FA466.20003@rece.vub.ac.be> <570fb1a3$0$1609$c3e8da3$5496439d@news.astraweb.com> <57108FAC.3020105@rece.vub.ac.be> Xref: csiph.com comp.lang.python:107029 Op 15-04-16 om 09:42 schreef Chris Angelico: > On Fri, Apr 15, 2016 at 4:52 PM, Antoon Pardon > wrote: >> Op 14-04-16 om 17:05 schreef Steven D'Aprano: >>> On Fri, 15 Apr 2016 12:08 am, Antoon Pardon wrote: >>> >>>> I have a unittest for my avltree module. >>>> >>>> Now I want this unittest to also run on a subclass of avltree. >>>> How can I organise this, so that I can largely reuse the >>>> original TestCase? >>> class Test_AVLTree(unittest.TestCase): >>> tree = avltree >>> >>> def test_empty_tree_is_false(self): >>> instance = self.tree() >>> self.assertFalse(instance) >>> >>> >>> class Test_MySubclassTree(Test_AVLTree): >>> tree = My_Subclass_Tree >> I see, that's going to be a lot of cut & pastes. >> Thanks. > Not really; the first class has all the tests, and the second one is > literally just those two lines. It overrides 'tree' (accessed inside > methods as 'self.tree'), and since all the tests are written to > instantiate self.tree, they are effectively parameterized. But the tests, at this moment, are not written to instantiate self.tree but to call avltree directly. So I have to rewrite these tests. That will IMO involve a lot of cut and paste. -- Antoon.