Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!aioe.org!feeder.news-service.com!feeder.news-service.com!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.007 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'arguments': 0.05; 'subject:Python': 0.06; 'decorator': 0.09; 'naturally': 0.09; 'not?': 0.09; 'am,': 0.13; 'wrote:': 0.15; 'parentheses': 0.16; 'argument': 0.16; 'cc:addr:python-list': 0.16; '(i.e.': 0.17; 'cheers,': 0.19; 'cc:2**0': 0.21; 'cc:no real name:2**0': 0.22; 'header:In-Reply-To:1': 0.22; 'optional': 0.23; 'tue,': 0.23; 'work.': 0.28; 'concern': 0.28; 'message-id:@mail.gmail.com': 0.28; 'cc:addr:python.org': 0.30; 'decorators': 0.30; 'least': 0.31; 'people,': 0.33; 'instead': 0.34; 'normally': 0.34; 'all.': 0.35; 'skip:@ 10': 0.35; 'guys': 0.36; 'certain': 0.36; 'explain': 0.36; 'some': 0.37; 'but': 0.37; 'using': 0.37; 'received:google.com': 0.38; 'received:209.85.161': 0.38; 'received:209.85': 0.38; 'subject:: ': 0.38; 'think': 0.38; 'either': 0.39; 'subject:with': 0.39; 'received:209': 0.40; 'views': 0.40; 'advantages': 0.77; '10:52': 0.84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=I83f2PLp4Nd7vtPnm7IdY+hYgPFnNdLh4eCKIHA73Ao=; b=vHFRtx58t5TkJvVag1kgcjMD9EIiJz3FZ4K2Q5ZJEnzK06WPGD4zUV3Xg39tM8yWdC jjOsIJ45cxEDvh39pGx3PodDt/JbjTemhUCbisLwSO95HoL0OnE6tLM3L6lkGhDKMOcj d1yUfvzZv1zTa64lTY1EIugEAGjTto+dkjSa8= MIME-Version: 1.0 In-Reply-To: References: From: Ian Kelly Date: Tue, 28 Jun 2011 11:20:29 -0600 Subject: Re: Using decorators with argument in Python To: Jigar Tanna Content-Type: text/plain; charset=ISO-8859-1 Cc: python-list@python.org X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 25 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1309281662 news6.xs4all.nl 4354 [2001:888:2000:d::a6]:57891 X-Complaints-To: abuse@xs4all.nl Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:8541 On Tue, Jun 28, 2011 at 10:52 AM, Jigar Tanna wrote: > coming across to certain views from people, it is not a good practice > to use > decorators with arguments (i.e. @memoize() ) and instead it is good to > just > use @memoize. Can any of you guys explain me advantages and > disadvantages of > using each of them The main concern I think is not with how the decorators are used but how they are designed. An argument-less decorator will normally be used as @memoize, and @memoize() will likely not work. A decorator with arguments that are all optional will normally be used as @memoize(), and @memoize will likely not work. This naturally leads to some confusion: do I need parentheses to use this particular decorator or not? As a personal design goal I try to make my decorators either take at least one required argument or take no arguments at all. This way it's either @memoize or @memoize(foo), but never just the confusing @memoize(). Cheers, Ian