Path: csiph.com!usenet.pasdenom.info!news.franciliens.net!news.muarf.org!nntpfeed.proxad.net!proxad.net!feeder1-2.proxad.net!usenet-fr.net!nerim.net!novso.com!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.193 X-Spam-Level: * X-Spam-Evidence: '*H*': 0.65; '*S*': 0.04; 'method.': 0.07; 'def': 0.12; 'factory': 0.16; 'merely': 0.16; 'wrote:': 0.18; 'separate': 0.22; 'updating': 0.26; 'header:In-Reply-To:1': 0.27; 'function': 0.29; 'am,': 0.29; 'skip:@ 10': 0.30; 'message- id:@mail.gmail.com': 0.30; 'factor': 0.31; 'probably': 0.32; 'skip:c 30': 0.32; 'skip:d 20': 0.34; "i'd": 0.34; 'received:google.com': 0.35; 'yield': 0.36; 'to:addr:python-list': 0.38; 'to:addr:python.org': 0.39; 'skip:u 10': 0.60; 'access,': 0.60; "you're": 0.61; 'frank': 0.68; 'jul': 0.74; 'repeat': 0.74; 'reading,': 0.84; 'writing,': 0.84; '2013': 0.98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=Xfn3a422+u8qKGGl1la19PqFWWDnBp3ZOXFzWc+59N8=; b=Coa9CYW3gd7wAhpyBDAj4DVwUML7Sw+V8Fr3rYnCOg4MYIaymL61EdsHpUyKn/7NE4 a9DM86oReGGW3bm6m+F5YfP7lXfjeGKtyxTh6idsHeACCmVRxQpz1W4AyaAW639roEyN TUpnhHQClAtCTpUvC0dbEfdRYpY0KWLzABwN6t4gOAq8o2/jeABkc17NaycfZejzuaPX L8Gjv76Eed9k2cQVAaTvFDqjshyEUXfUlHMFZ10TTGdTHwH1DOZyyEucf14zN1oowJ2S sOTMPf/Ln1DhbudytWzElIsl2bRM5kGLnYa1IHHCDl5jVRL93FGDbb8uobwF6H16i2Qm QKkQ== X-Received: by 10.68.164.225 with SMTP id yt1mr24680537pbb.195.1373356629254; Tue, 09 Jul 2013 00:57:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <51d4eb9c$0$29999$c3e8da3$5496439d@news.astraweb.com> <51d508ed$0$6512$c3e8da3$5496439d@news.astraweb.com> <51d5a504$0$29999$c3e8da3$5496439d@news.astraweb.com> From: Ian Kelly Date: Tue, 9 Jul 2013 01:56:29 -0600 Subject: Re: Default scope of variables To: Python Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 23 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1373356631 news.xs4all.nl 15984 [2001:888:2000:d::a6]:37638 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:50223 On Tue, Jul 9, 2013 at 1:35 AM, Frank Millman wrote: > When any of them need any database access, whether for reading or for > updating, they execute the following - > > with db_session as conn: > conn.transaction_active = True # this line must be added if > updating > conn.cur.execute(__whatever__) I'd probably factor out the transaction_active line into a separate DbSession method. @contextmanager def updating(self): with self as conn: conn.transaction_active = True yield conn Then you can do "with db_session" if you're merely reading, or "with db_session.updating()" if you're writing, and you don't need to repeat the transaction_active line all over the place. I would also probably make db_session a factory function instead of a global.