Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder4.news.weretis.net!rt.uk.eu.org!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <51daaa51$0$9505$c3e8da3$5496439d@news.astraweb.com>
References: <CAAF+z6Hp=TZJwcDgyT94cv6Mx3Gy4gxSiZ640b9voAAjgsi6dw@mail.gmail.com> <mailman.4380.1373280314.3114.python-list@python.org> <51daaa51$0$9505$c3e8da3$5496439d@news.astraweb.com>
From: Joshua Landau <joshua.landau.ws@gmail.com>
Date: Mon, 8 Jul 2013 14:07:30 +0100
Subject: Re: A small question about PEP 8
To: "Steven D'Aprano" <steve+comp.lang.python@pearwood.info>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: python-list <python-list@python.org>
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.4386.1373288900.3114.python-list@python.org>
Lines: 88
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:50153

On 8 July 2013 13:02, Steven D'Aprano
<steve+comp.lang.python@pearwood.info> wrote:
> On Mon, 08 Jul 2013 11:39:21 +0100, Joshua Landau wrote:
>  Imagine:
>>
>> """
>> a_wonderful_set_of_things =3D {
>>     bannanas_made_of_apples,
>>     chocolate_covered_horns,
>>     doors_that_slide,
>>     china_but_on_the_moon,
>>     buffalo_with_windy_hair,
>>     not_missing_an_end_brace
>> """=C2=B9
>>
>> Now, there are several places you can put the end brace. You can (be a
>> massive fool and) put it after the last item:
>>
>> """
>> a_wonderful_set_of_things =3D {
>>     ...,
>>     not_missing_an_end_brace}
>> """
>
> Well, call me a fool then, because when I have code that extends over
> *one* additional line, I prefer that:
>
>     raise ValueError(
>             "Some error message too long to fit on the above line")
>
> rather than:
>
>     raise ValueError(
>             "Some error message too long to fit on the above line"
>             )

Fool.

>> You can also (be a fool and) put it at the same *indentation*:
>>
>> """
>> a_wonderful_set_of_things =3D {
>>     ...,
>>     not_missing_an_end_brace
>>     }
>> """
>
> Call me a fool again, since I prefer this when there are more than one
> additional line. At least this time I'm in good company, since that's
> recommended by PEP 8.

Fool (less so, though).

>> Or you can (be sane) and put it at no indentation:
>>
>> """
>> a_wonderful_set_of_things =3D {
>>     ...,
>>     not_missing_an_end_brace
>> }
>> """
>
> I consider that the least aesthetically pleasing, and also rather awkward=
:
>
>
> some_result =3D some_function(
>         arg1, arg2, arg3, arg4,
>         [item1, item2, item3, item4,
>               item5, item6, item7,
>               item8, item9, item10,
> ],
>        arg6, key=3Dspam, word=3Deggs,
>        extras=3DNone, foo=3Dbar,
> )

http://xkcd.com/605/

It was obvious=C2=B9 I was talking in context of my example. I used "no
indentation" because in that case "no indentation" was correct. If you
indent line #1, it follows that other lines might well be indented to
keep style consistent.

=C2=B9 I hope. I never suggested otherwise.

Since it's not too clear for you, my usage of fool was meant
pseudoironically as a subtle reminder that it's all subjective anyway,
but that I'm also still right.