Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!news.tele.dk!news.tele.dk!small.news.tele.dk!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Return-Path: <python-python-list@m.gmane.org>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.000
X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'python,': 0.02; 'argument': 0.05; 'string': 0.09; 'arguments': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'subject:files': 0.09; '(also': 0.16; 'message-id:@4ax.com': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'subject:CSV': 0.16; 'subject:based': 0.16; 'tends': 0.16; 'passing': 0.19; 'result.': 0.19; 'thu,': 0.19; 'error': 0.23; 'url:home': 0.24; 'first,': 0.26; 'second': 0.26; 'pass': 0.26; 'header:X-Complaints-To:1': 0.27; 'dec': 0.30; 'probably': 0.32; 'cases': 0.33; 'subject:from': 0.34; 'skip:u 20': 0.35; 'doing': 0.36; 'charset:us-ascii': 0.36; 'should': 0.36; 'received:76': 0.38; 'to:addr:python-list': 0.38; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'skip:u 10': 0.60; 'most': 0.60; '2013': 0.98
X-Injected-Via-Gmane: http://gmane.org/
To: python-list@python.org
From: Dennis Lee Bieber <wlfraed@ix.netcom.com>
Subject: Re: Downloading multiple files based on info extracted from CSV
Date: Thu, 12 Dec 2013 20:52:39 -0500
Organization: IISS Elusive Unicorn
References: <88346903-2af8-48cd-9829-37cedb717ae5@googlegroups.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Gmane-NNTP-Posting-Host: adsl-76-249-30-188.dsl.klmzmi.sbcglobal.net
X-Newsreader: Forte Agent 6.00/32.1186
X-No-Archive: YES
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.4043.1386899560.18130.python-list@python.org>
Lines: 26
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1386899560 news.xs4all.nl 2872 [2001:888:2000:d::a6]:34601
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:61781

On Thu, 12 Dec 2013 13:43:50 -0800 (PST), Matt Graves <tunacubes@gmail.com>
declaimed the following:

>def downloadFile(urls, clientname):
>    urllib.urlretrieve(f, "%g.csv") % clientname
>
	The most blatent error is this line...

	You are calling urllib.urlretrieve passing it arguments of f and the
string "%g.csv".

	THEN you are doing a string interpolation on the RESULT.

	The line should probably be

	urllib.urlretrieve(f, "%s.csv" % clientname)

to apply the string interpolation first, and pass that as the second
argument (also not the %s for /string/ [which, in Python, tends to accept
any argument and produce a general string from it -- using any other format
specification tends to be for cases where you need to match a particular
format... %4.4x if you want zero-filled hex, for example])
-- 
	Wulfraed                 Dennis Lee Bieber         AF6VN
    wlfraed@ix.netcom.com    HTTP://wlfraed.home.netcom.com/