Path: csiph.com!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder1.hal-mli.net!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'algorithm': 0.04; 'output': 0.05; 'needed,': 0.07; 'indexes': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'python': 0.11; 'jan': 0.12; 'aiming': 0.16; 'before.': 0.16; 'comp': 0.16; 'discarded.': 0.16; 'expressions.': 0.16; 'in-place': 0.16; 'iterable': 0.16; 'iterators': 0.16; 'itertools': 0.16; 'once.': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'reedy': 0.16; 'slow,': 0.16; 'table;': 0.16; 'tuple': 0.16; 'underlying': 0.16; 'unpacking': 0.16; '(you': 0.16; 'index': 0.16; 'wrote:': 0.18; 'code.': 0.18; 'slightly': 0.19; 'value.': 0.19; 'examples': 0.20; 'meant': 0.20; 'fit': 0.20; 'work,': 0.20; 'input': 0.22; 'memory': 0.22; 'import': 0.22; 'header:User- Agent:1': 0.23; 'looks': 0.24; 'equivalent': 0.26; 'least': 0.26; 'values': 0.27; 'gets': 0.27; 'header:X-Complaints-To:1': 0.27; 'header:In-Reply-To:1': 0.27; '(this': 0.29; 'besides': 0.30; 'expansion': 0.30; 'needed.': 0.30; 'subject:list': 0.30; 'code': 0.31; 'lines': 0.31; 'usually': 0.31; "d'aprano": 0.31; 'produces': 0.31; 'steven': 0.31; 'lists': 0.32; 'table': 0.34; 'skip:_ 10': 0.34; 'skip:d 20': 0.34; 'problem': 0.35; 'something': 0.35; 'but': 0.35; 'version': 0.36; 'done': 0.36; 'method': 0.36; 'shows': 0.36; 'should': 0.36; 'so,': 0.37; 'two': 0.37; 'list': 0.37; 'expected': 0.38; 'depends': 0.38; 'filled': 0.38; 'saves': 0.38; 'to:addr:python-list': 0.38; 'list,': 0.38; 'fact': 0.38; 'pm,': 0.38; 'rather': 0.38; 'expect': 0.39; 'does': 0.39; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'skip:u 10': 0.60; 'length': 0.61; 'received:173': 0.61; 'course': 0.61; 'zip': 0.64; 'temporary': 0.65; 'here': 0.66; 'below.': 0.71; 'million': 0.74; 'potentially': 0.81; 'avoids': 0.84; 'decorate': 0.84; 'enumeration': 0.84; 'obvious.': 0.84; 'received:fios.verizon.net': 0.84 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Terry Reedy Subject: Re: Optimizing list processing Date: Wed, 11 Dec 2013 21:26:51 -0500 References: <52a8fb2d$0$29992$c3e8da3$5496439d@news.astraweb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: pool-173-75-254-207.phlapa.fios.verizon.net User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <52a8fb2d$0$29992$c3e8da3$5496439d@news.astraweb.com> X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 68 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1386815228 news.xs4all.nl 2836 [2001:888:2000:d::a6]:40405 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:61650 On 12/11/2013 6:54 PM, Steven D'Aprano wrote: > I have some code which produces a list from an iterable using at least > one temporary list, using a Decorate-Sort-Undecorate idiom. It is a non-standard version thereof, as DSU usually means to decorate with a key that gets discarded. A couple of examples of input and expected output would have been good ;-). > The algorithm looks something like this (simplified): > > table = sorted([(x, i) for i,x in enumerate(iterable)]) This makes two temporaries when only one is needed, and shows why we added generator expressions. table = sorted((x, i) for i,x in enumerate(iterable)) is equivalent to the table; table.sort lines below. The following (untested) should be faster as it avoids tuple unpacking and repacking. from itertools import count table = sorted(t for t in zip(iterable, count)) > table = [i for x,i in table] Did your original un-simplified use zip instead enumerate? Table now has the original index of the items in iterable sorted by the items value. The use for this is not obvious. > The problem here is that for large iterables, say 10 million items or so, > this is *painfully* slow, as my system has to page memory like mad to fit > two large lists into memory at once. So I came up with an in-place > version that saves (approximately) two-thirds of the memory needed. With 1/3 saved by using a genex, it saves 1/2 of the remainder. > table = [(x, i) for i,x in enumerate(iterable)] > table.sorted() (You meant table.sort().) This is an expansion of sorted(genex). It might be slightly faster as list comp may be faster than list(equivalent genex). > for x, i in table: > table[i] = x I cannot understand what you are aiming for here. Besides the fact that this does not work, it keeps x values rather than i indexes as before. > table = [i for x,i in table] done in place is for j, (x,i) in enumerate(table): table[j] = i I expect the list comp be faster than in-place as long as the result list can be allocated and held in memory without paging. (This of course depends on system memory and other memory uses.) List iterators have a __length_hint__ method giving the length of the underlying list, so the list comp result list can potentially be allocated once and then filled in by enumeration and replacement, but in C rather than Python code. -- Terry Jan Reedy