Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <CALwzidnGdNhfCAiGSAzU6bASCRdof_VGZAL_MCzGx0+dFUKb4A@mail.gmail.com>
References: <ash6s8-qj5.ln1@satorlaser.homedns.org> <nbr6s8-n86.ln1@satorlaser.homedns.org> <CALwzidnGdNhfCAiGSAzU6bASCRdof_VGZAL_MCzGx0+dFUKb4A@mail.gmail.com>
From: Ian Kelly <ian.g.kelly@gmail.com>
Date: Tue, 20 Dec 2011 11:55:59 -0700
Subject: Re: nesting context managers
To: Ulrich Eckhardt <ulrich.eckhardt@dominolaser.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: python-list@python.org
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.3875.1324407391.27778.python-list@python.org>
Lines: 78
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:17601

On Tue, Dec 20, 2011 at 11:46 AM, Ian Kelly <ian.g.kelly@gmail.com> wrote:
> On Tue, Dec 20, 2011 at 9:56 AM, Ulrich Eckhardt
> <ulrich.eckhardt@dominolaser.com> wrote:
>> Am 20.12.2011 15:15, schrieb Ulrich Eckhardt:
>>
>>> Let us assume I had a class HTTPClient that has a socket for HTTP and a
>>> logfile for filing logs. I want to make this HTTPClient a context
>>> manager, so that I can write
>>>
>>> with HTTPClient(url) as client:
>>> =A0 =A0pass
>>
>>
>> Actually, I overestimated the task:
>>
>> =A0class HTTPClient(url):
>> =A0 =A0 =A0def __enter__(self):
>> =A0 =A0 =A0 =A0 =A0return self
>> =A0 =A0 =A0def __exit__(self, ctx_type, ctx_val, ctx_tb):
>> =A0 =A0 =A0 =A0 =A0self.close()
>> =A0 =A0 =A0def close(self):
>> =A0 =A0 =A0 =A0 =A0self._myfile.close()
>> =A0 =A0 =A0 =A0 =A0self._mysocket.close()
>>
>> I'll simply ignore the fact that closing a file can fail if you can't fl=
ush
>> buffers. Now, my error was that I have to somehow invoke the file's and
>> socket's enter function in my client's enter function. The default for a=
ll
>> files and sockets is that they are already open, they are not opened in =
the
>> enter function! That way, the client remains usable outside a with conte=
xt
>> but gives me the desired guarantees inside one.
>>
>> For the case of on-demand allocated stuff, I could write the enter funct=
ion
>> like this:
>>
>> =A0def __enter__(self):
>> =A0 =A0 =A0# allocate resources
>> =A0 =A0 =A0f =3D ... # open file
>> =A0 =A0 =A0s =3D ... # connect socket
>> =A0 =A0 =A0# attach after completion
>> =A0 =A0 =A0self._myfile =3D f
>> =A0 =A0 =A0self._mysocket =3D s
>>
>> To be extra safe or in more complicated scenarios, I could wrap this in =
a
>> try-except and explicitly close those that were already created, but
>> normally I'd expect the garbage collector to do that for me ... or am I =
then
>> implicitly assuming a specific implementation?
>
> For full generality, copy the code for the contextlib.nested function
> in Python 2.7 or 3.1 and use that. =A0Don't use contextlib.nested
> itself, though, because it's deprecated and does not exist in Python
> 3.2.

Also note that in versions that do support the nested with syntax, you
can do something like:

class HTTPClient(url):
    @contextlib.contextmanager
    def _contextmanager(file, socket):
        with file, socket:
            yield
    def __enter__(self):
        self._cm =3D self._contextmanager(self._myfile, self._mysocket)
        return self._cm.__enter__()
    def __exit__(self, exc_type, exc_value, traceback):
        try:
            return self._cm.__exit__(exc_type, exc_value, traceback)
        finally:
            del self._cm

Cheers,
Ian