Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!ecngs!feeder2.ecngs.de!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Return-Path: <tolidtm@gmail.com>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.027
X-Spam-Evidence: '*H*': 0.95; '*S*': 0.00; 'ignored': 0.05; 'function,': 0.07; 'parsing': 0.07; 'ignoring': 0.09; 'subject:files': 0.09; 'cc:addr:python-list': 0.10; 'belongs': 0.16; 'cleaner': 0.16; 'similarly,': 0.16; 'input': 0.18; 'constant': 0.22; 'nearly': 0.23; 'cc:no real name:2**0': 0.24; 'cc:2**1': 0.24; 'cc:addr:python.org': 0.25; 'header:In-Reply- To:1': 0.25; 'message-id:@mail.gmail.com': 0.27; 'subject:list': 0.28; "i'm": 0.29; 'stuff': 0.30; '(and': 0.32; 'file': 0.32; 'received:google.com': 0.34; 'updated': 0.34; 'lists.': 0.35; 'returning': 0.35; 'received:209.85': 0.35; 'but': 0.36; 'anything': 0.36; 'should': 0.36; 'received:209': 0.37; 'data': 0.37; 'subject:: ': 0.38; 'files': 0.38; 'called': 0.39; 'header:Received:5': 0.40; 'end': 0.40; "you've": 0.61; 'containing': 0.61; 'different': 0.63; 'more': 0.63; 'therefore': 0.65; 'promise': 0.65; 'treat': 0.65; "it'd": 0.84; 'modify.': 0.84
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=USXfzTVYdiYepnp0bzPFeqy5J8JGlM20n/wUlcanWUk=; b=Iwyw7wSXu/xSfiOyGOPpLv1PaoYXi+rAzf9hGf62oMCcFXrIu4vHwFsWVHyU9/5+jw tiOfz0lZJxNT0St/XvO4I9Vdpl/IJy7zqnBLTgpDAUpJYbu2HyDb/NgScWsfLiAvgYFb wBVTZsMuCuLPSZIf9aW3kwC8+c6ugCG8d6XM7r/RmOnbcVhttPfOrCYexjtjUCflLwEV 9Dyn7JMDogRv2Fzc80ZasISdmEriYw2R9w1zDJitmMYObANsFuypo/aO8oVpIdq1dOVL aHD7NK8htFVX66ItZRFPQ8oEwXpdcfph0o6mJ6PSnJI+5nT7tgg3OulIWfE08cu8th+E ZECA==
MIME-Version: 1.0
In-Reply-To: <50B82535.8050301@davea.name>
References: <CAKhY55M3iOhhMbn=VuwJ7OMz_JUHVxwGy1h_BDpfBY8jQ5aRkA@mail.gmail.com> <50B3E865.9070700@davea.name> <CAKhY55OUNvGFhCjZLS7HNoDydKqHxZrnaN+bWySCsmKSk1vqsw@mail.gmail.com> <50B43246.2010902@davea.name> <mailman.313.1354026304.29569.python-list@python.org> <ahk36lFeqmlU3@mid.individual.net> <mailman.320.1354042676.29569.python-list@python.org> <ahkmslFk897U1@mid.individual.net> <CAKhY55OdS7sHDpAg3kdnpqWH5yoORqzE0bTHJVgMWZSHqqZ4kQ@mail.gmail.com> <50B82535.8050301@davea.name>
Date: Fri, 30 Nov 2012 10:29:09 +0100
Subject: Re: Compare list entry from csv files
From: Anatoli Hristov <tolidtm@gmail.com>
To: d@davea.name
Content-Type: text/plain; charset=UTF-8
Cc: python-list@python.org, Neil Cerutti <neilc@norwich.edu>
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <http://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <http://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.379.1354267752.29569.python-list@python.org>
Lines: 19
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1354267752 news.xs4all.nl 6871 [2001:888:2000:d::a6]:33908
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:34091

> As I said before, process both files into lists, one that you treat as
> constant (and therefore capitalized) and the other containing the data
> you intend to modify.
>
> It'd be much cleaner if you did all that input file parsing stuff in one
> function, returning only the lists.  Call it just before calling
> name_find().  Similarly, the part you have at the end belongs in a
> different function, called just after calling name_find().
>
> There's lots of other stuff that should be cleaner, but you've ignored
> nearly all the suggestions from various people.

I'm not ignoring anything I just need more time :) I will clean all up
and will keep you updated - I promise


Regards

Anatoli