Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!rt.uk.eu.org!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.003 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'url:sourceforge': 0.03; 'algorithm': 0.04; 'from:addr:yahoo.co.uk': 0.04; 'dan': 0.09; 'friday,': 0.09; 'lawrence': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'language.': 0.14; 'comments:': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'samstag,': 0.16; 'language': 0.16; 'thanks,': 0.17; 'wrote:': 0.18; 'code.': 0.18; 'header:User-Agent:1': 0.23; 'url:moin': 0.24; 'read,': 0.26; 'header:X-Complaints-To:1': 0.27; 'header:In- Reply-To:1': 0.27; 'function': 0.29; 'dec': 0.30; 'robert': 0.30; 'code': 0.31; 'lines': 0.31; 'url:wiki': 0.31; 'subject:some': 0.31; 'anyone': 0.31; 'url:python': 0.33; 'fri,': 0.33; 'december': 0.35; 'tool': 0.35; "who's": 0.35; 'there': 0.35; 'largely': 0.36; 'thanks': 0.36; "i'll": 0.36; 'url:org': 0.36; 'performance': 0.37; 'to:addr:python-list': 0.38; 'pm,': 0.38; 'does': 0.39; 'to:addr:python.org': 0.39; 'enough': 0.39; 'received:org': 0.40; 'tell': 0.60; 'john': 0.61; "you're": 0.61; 'kind': 0.63; 'our': 0.64; 'here': 0.66; 'below.': 0.71; 'detecting': 0.84; 'glance': 0.84; '2013': 0.98 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Mark Lawrence Subject: Re: squeeze out some performance Date: Mon, 09 Dec 2013 14:52:54 +0000 References: <9df6ccd7-828d-43be-ac49-fe1c6a38bae7@googlegroups.com> <5320aa30-8ea5-4680-8796-ef2c7dac3984@googlegroups.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Gmane-NNTP-Posting-Host: host-78-147-190-160.as13285.net User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: <5320aa30-8ea5-4680-8796-ef2c7dac3984@googlegroups.com> X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 53 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1386600779 news.xs4all.nl 2969 [2001:888:2000:d::a6]:52802 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:61389 On 09/12/2013 14:19, Robert Voigtländer wrote: > Am Samstag, 7. Dezember 2013 00:01:49 UTC+1 schrieb Dan Stromberg: >> On Fri, Dec 6, 2013 at 2:38 PM, Mark Lawrence wrote: >> >> >> On 06/12/2013 16:52, John Ladasky wrote: >> >> >> On Friday, December 6, 2013 12:47:54 AM UTC-8, Robert Voigtländer wrote: >> >> >> >> >> I try to squeeze out some performance of the code pasted on the link below. >> >> http://pastebin.com/gMnqprST >> >> >> >> >> Several comments: >> >> >> >> 1) I find this program to be very difficult to read, largely because there's a whole LOT of duplicated code. Look at lines 53-80, and lines 108-287, and lines 294-311. It makes it harder to see what this algorithm actually does. Is there a way to refactor some of this code to use some shared function calls? >> >> >> >> >> >> >> >> A handy tool for detecting duplicated code here http://clonedigger.sourceforge.net/ for anyone who's interested. >> >> >> >> Pylint does this too... > > Thanks again. I'll try to compress the code and have a look at the "multiple comparisons" topic. > > Robert > Would you be kind enough to compress your messages while you're at it by reading and actioning https://wiki.python.org/moin/GoogleGroupsPython thanks, a quick glance above will tell you why :) -- My fellow Pythonistas, ask not what our language can do for you, ask what you can do for our language. Mark Lawrence