Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'python.': 0.02; 'continuation': 0.07; 'follows.': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'skip:% 20': 0.09; 'subject:question': 0.10; 'python': 0.11; 'jan': 0.12; 'wrote': 0.14; 'code?': 0.16; 'indent': 0.16; 'pep8': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'reedy': 0.16; 'splitting': 0.16; 'terribly': 0.16; 'wrote:': 0.18; 'rules': 0.22; 'header :User-Agent:1': 0.23; 'question': 0.24; 'code:': 0.26; 'header:X -Complaints-To:1': 0.27; 'header:In-Reply-To:1': 0.27; 'point': 0.28; 'function': 0.29; 'code': 0.31; 'lines': 0.31; 'breaking': 0.31; 'reader': 0.33; 'screen': 0.34; 'skip:s 30': 0.35; 'there': 0.35; 'really': 0.36; 'hi,': 0.36; 'to:addr:python-list': 0.38; 'fact': 0.38; 'pm,': 0.38; 'to:addr:python.org': 0.39; 'either': 0.39; 'received:org': 0.40; 'new': 0.61; 'received:173': 0.61; 'eyes': 0.78; 'calls,': 0.84; 'ok?': 0.84; 'received:fios.verizon.net': 0.84 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Terry Reedy Subject: Re: n00b question on spacing Date: Fri, 21 Jun 2013 18:33:13 -0400 References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: pool-173-75-251-66.phlapa.fios.verizon.net User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 31 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1371854012 news.xs4all.nl 15956 [2001:888:2000:d::a6]:50523 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:48888 On 6/21/2013 5:17 PM, Yves S. Garret wrote: > Hi, I have a question about breaking up really long lines of code in Python. > > I have the following line of code: > log.msg("Item wrote to MongoDB database %s/%s" %(settings['MONGODB_DB'], > settings['MONGODB_COLLECTION']), level=log.DEBUG, spider=spider) > > Given the fact that it goes off very far to the right on my screen is > not terribly > pleasing to my eyes (and can be rude for other developers). > > I was thinking of splitting it up like so: > log.msg("Item wrote to MongoDB database %s/%s" > %(settings['MONGODB_DB'], settings['MONGODB_COLLECTION']), > level=log.DEBUG, spider=spider) > > Is this ok? Are there any rules in Python when it comes to breaking up > long lines of code? For function calls, PEP8 suggests either an extra indent or line up as follows. log.msg("Item wrote to MongoDB database %s/%s" %(settings['MONGODB_DB'], settings['MONGODB_COLLECTION']), level=log.DEBUG, spider=spider) The point is to not look like a normal indent to clue reader that these are continuation lines and not new statements. -- Terry Jan Reedy