Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.047 X-Spam-Evidence: '*H*': 0.91; '*S*': 0.00; 'say,': 0.05; 'stops': 0.07; 'strings.': 0.07; 'cases': 0.15; 'discussions': 0.15; '22:50,': 0.16; 'benjamin': 0.16; 'for,': 0.16; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'intern': 0.16; 'unequal': 0.16; 'string': 0.17; 'wrote:': 0.17; 'char': 0.17; 'comparing': 0.17; 'code,': 0.18; 'discussion': 0.20; "haven't": 0.23; 'header:In-Reply-To:1': 0.25; 'bugs': 0.27; 'message-id:@mail.gmail.com': 0.27; 'chris': 0.28; 'comparison': 0.29; 'faster,': 0.29; 'obscure': 0.29; "they'll": 0.29; 'though.': 0.29; 'unlikely': 0.29; 'source': 0.29; 'subject: ?': 0.30; 'checked': 0.30; '(and': 0.32; 'url:python': 0.32; 'problem': 0.33; 'anyone': 0.33; 'to:addr:python-list': 0.33; 'point.': 0.33; 'received:google.com': 0.34; 'list': 0.35; 'compared': 0.35; 'nov': 0.35; 'pm,': 0.35; 'received:209.85': 0.35; 'really': 0.36; 'but': 0.36; 'url:org': 0.36; 'characters': 0.36; 'compare': 0.36; 'subject:with': 0.36; 'correctly': 0.37; 'two': 0.37; 'being': 0.37; 'quite': 0.37; 'received:209': 0.37; 'subject:: ': 0.38; 'some': 0.38; 'things': 0.38; 'shows': 0.38; 'to:addr:python.org': 0.39; 'where': 0.40; 'header:Received:5': 0.40; 'end': 0.40; 'worth': 0.63; 'here': 0.65; 'identity.': 0.65; 'potentially': 0.66; 'color': 0.69; 'heavy': 0.83; 'conclude': 0.84; 'confusing': 0.84; 'optimized,': 0.84; 'oscar': 0.84; 'url:cpython': 0.84; 'prone': 0.91; 'outcome': 0.93; 'imagine': 0.96 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=LaFSP0bFkShwXpwX2m+ql4V8Pnnto+rIxw1glqt4qDE=; b=G4Q23ZQQbeLrtwcWdTvJDLgmWyUH2+BxJe4vNA4ltH2cQ8jCDYoJlb0Cy2UAMFBPIX AVQXVicRLW2kGgRlzPi/vrxGspwPN2L9QGhr0vSTbBVFHRPkOOK8Ltxp9/jg+nbSKJKh AiNjJbVB1A59HAa2NVjcaX9Wc4kAK6lzFK0gxpGPyRSvkGlDr6/JYKWAH8mnW7yNeO8G 6StKDMDYJoQK+a4jrNcOK6UpiEzIqCun49+gSVnsKYCjOPOw48AIPq7RmCuBGQMMIPga oVF67953vB7oNBWzyo4U+hwDu71ggC0yryAuH9t4EjIIQ8Om86ZzbBC2YaUqDCsQt6YR xPtw== MIME-Version: 1.0 In-Reply-To: References: <50475822$0$6867$e4fe514c@news2.news.xs4all.nl> <50959154$0$6880$e4fe514c@news2.news.xs4all.nl> <50959827$0$29967$c3e8da3$5496439d@news.astraweb.com> Date: Sun, 4 Nov 2012 12:22:17 +1100 Subject: Re: is implemented with id ? From: Chris Angelico To: python-list@python.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 31 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1351992140 news.xs4all.nl 6905 [2001:888:2000:d::a6]:52810 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:32711 On Sun, Nov 4, 2012 at 12:14 PM, Oscar Benjamin wrote: > On 3 November 2012 22:50, Chris Angelico wrote: >> This one I haven't checked the source for, but ISTR discussions on >> this list about comparison of two unequal interned strings not being >> optimized, so they'll end up being compared char-for-char. Using 'is' >> guarantees that the check stops with identity. This may or may not be >> significant, and as you say, defending against an uninterned string >> slipping through is potentially critical. > > The source is here (and it shows what you suggest): > http://hg.python.org/cpython/file/6c639a1ff53d/Objects/unicodeobject.c#l6128 > > Comparing strings char for char is really not that big a deal though. > This has been discussed before: you don't need to compare very many > characters to conclude that strings are unequal (if I remember > correctly you were part of that discussion). Yes, and a quite wide-ranging discussion it was too! What color did we end up whitewashing that bikeshed? *whistles innocently* > I can imagine cases where I might consider using intern on lots of > strings to speed up comparisons but I would have to be involved in > some seriously heavy and obscure string processing problem before I > considered using 'is' to compare those interned strings. That is > confusing to anyone who reads the code, prone to bugs and unlikely to > achieve the desired outcome of speeding things up (noticeably). Good point. It's still true that 'is' will be faster, it's just not worth it. ChrisA