Path: csiph.com!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder1.hal-mli.net!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
Sender: lucafbb@gmail.com
In-Reply-To: <l6ql3s$fkc$1@ger.gmane.org>
References: <CAGfGq=ax9rHaiVYuKmkF4b8fTN_VyXznyzkoHq4FHcJ_W6BhOQ@mail.gmail.com> <l6ql3s$fkc$1@ger.gmane.org>
From: Luca Fabbri <luca@keul.it>
Date: Sat, 23 Nov 2013 18:23:12 +0100
Subject: Re: Using sh library with grep command
To: Peter Otten <__peter__@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "Python-list \(General\)" <python-list@python.org>
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.3097.1385227421.18130.python-list@python.org>
Lines: 59
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:60316

On Sat, Nov 23, 2013 at 5:29 PM, Peter Otten <__peter__@web.de> wrote:
> Luca wrote:
>
>> I'm trying to use sh (https://pypi.python.org/pypi/sh) for calling
>> system grep command but it's now working as expected.
>>
>> An example:
>>
>>     import sh
>>     sh.grep('abc', os.getcwd(), '-r')
>>
>> But I get the ErrorReturnCode_1: exception, that I learned is the
>> normal exit code for grep command when it not found any match.
>>
>> The error instance object reported that the command run is:
>>
>>     *** ErrorReturnCode_1:
>>       RAN: '/usr/bin/grep abc /Users/keul/test_sh'
>>
>> Obviously manually running the command I get some output and exit code 0.
>>
>> Where I'm wrong?
>
> Did you run grep with or without the -r option?
>
> The code sample and the error message don't match. Maybe you accidentally
> left out the -r in your actual code.
>

Sorry all, it was a stupid error and I provided a bad example.

I was running...
   sh.grep('"abc"', os.getcwd(), '-r')

...and the output of the command inside the exception was exactly...
    RAN: '/usr/bin/grep "abc" /Users/keul/test_sh -r'

So, at first glance it was ok (copying/pasting it in in the terminal
return exactly was I expected).

The error? The doublequote inclusion.

Using this...
   sh.grep('abc', os.getcwd(), '-r')

...I  get this output...
    RAN: '/usr/bin/grep abc /Users/keul/test_sh -r'

But this time I get the expected result (both in terminal and python
env). So seems that when quoting you get a false positive right
command output but a wrong execution.


-- 
-- luca

twitter: http://twitter.com/keul
linkedin: http://linkedin.com/in/lucafbb
blog: http://blog.keul.it/