Path: csiph.com!usenet.pasdenom.info!news.albasani.net!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'bug.': 0.07; 'correct.': 0.07; 'invalidate': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'terry': 0.09; 'def': 0.10; 'exhausted': 0.16; 'iterator': 0.16; 'iterators': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'reedy': 0.16; 'subject:optimization': 0.16; 'wrote:': 0.17; 'jan': 0.18; '>>>': 0.18; 'defined': 0.22; 'header:In-Reply-To:1': 0.25; 'header:User- Agent:1': 0.26; 'am,': 0.27; 'header:X-Complaints-To:1': 0.28; 'subject:list': 0.28; 'objects': 0.29; 'skip:_ 10': 0.29; 'file': 0.32; 'point,': 0.33; 'to:addr:python-list': 0.33; 'self': 0.34; 'protocol': 0.35; 'received:org': 0.36; 'but': 0.36; 'method': 0.36; 'should': 0.36; 'does': 0.37; 'subject:: ': 0.38; 'mean': 0.38; 'object': 0.38; 'skip:o 20': 0.38; 'to:addr:python.org': 0.39; 'subject:-': 0.40; 'header:Received:5': 0.40; 'as:': 0.75; 'partially': 0.84; 'received:fios.verizon.net': 0.84 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Terry Reedy Subject: Re: Interesting list() un-optimization Date: Thu, 07 Mar 2013 15:29:00 -0500 References: <20130306215735.649932ee@bigbox.christie.dr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: pool-173-75-251-66.phlapa.fios.verizon.net User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 32 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1362688168 news.xs4all.nl 6867 [2001:888:2000:d::a6]:45685 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:40820 On 3/7/2013 11:00 AM, Ian Kelly wrote: > But on this point, you are correct. The mongoengine QuerySet.__iter__ > method is defined as: > > def __iter__(self): > self.rewind() > return self > > This is unfortunate design. Not only does it mean that the iterator's > __len__ method cannot be trusted (what should the __len__ of a > partially exhausted iterator return?), but it also means that requesting > an iterator over the QuerySet will also silently invalidate any > existing iterators. I view that design as a violation of the iterator protocol and hence a program bug. __iter__ should either *just* return self (if the self is an iterator) or return a new object (if self is a non-iterator iterable). File objects are iterators and .__iter__ does not rewind. >>> f = open("f:/python/mypy/tem.py") >>> next(f) 'class myit(list):\n' >>> f2 = iter(f) >>> f2 is f True >>> next(f2) " def __bytes__(self): return b'hello'\n" -- Terry Jan Reedy