Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!ecngs!feeder2.ecngs.de!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <508c810f$0$29967$c3e8da3$5496439d@news.astraweb.com>
References: <a533d812-480e-479b-9210-7097c2d70d73@a4g2000pbo.googlegroups.com> <mailman.2934.1351343030.27098.python-list@python.org> <508c810f$0$29967$c3e8da3$5496439d@news.astraweb.com>
From: Devin Jeanpierre <jeanpierreda@gmail.com>
Date: Sun, 28 Oct 2012 01:57:45 -0400
Subject: Re: attaching names to subexpressions
To: "Steven D'Aprano" <steve+comp.lang.python@pearwood.info>
Content-Type: text/plain; charset=UTF-8
Cc: python-list@python.org
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.2950.1351403908.27098.python-list@python.org>
Lines: 53
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:32302

On Sat, Oct 27, 2012 at 8:49 PM, Steven D'Aprano
<steve+comp.lang.python@pearwood.info> wrote:
> On Sat, 27 Oct 2012 15:03:38 +0200, Gelonida N wrote:
>
>> line = complex_exression
>> while line:
>>      do something with(line)
>>      line = complex_expression
>>
>> violates clearly the DRY principle  and the risk to change one line but
>> not the other is high.
-- snip --
> while True:
>      line = function(x, y, z)
>      if not line:
>          break
>      big ugly block of code
>
>
> There you go. DRY.

>> The 'canonical way'
>> while True:
>>      line = complex_expression
>>      if not line:
>>          break
>>      do_something_with(line)
>>
>> avoids this problem, but I was never really convinced about the beauty /
>> readbility of this construct.
>>
>> In
>> my opinion I shouldn't be obliged to read any of the indented lines of
>> the while statement on a first 'visual' pass through somebody elses code
>> and still be able to see what the loop iterates through.
>
> Fine. Then write your code as:
>
> line = function(x, y, z)
> while line:
>      do something with(line)
>      line = function(x, y, z)
>

We have a problem, and two solutions. Solution 1 has downside A, and
solution 2 has downside B. If he complains about downside A, you say,
well, use solution 2. If he complains about downside B, you say, well,
use solution 1.

What if he wants to avoid both downsides A and B? What solution does
he use then?

-- Devin