Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!gegeweb.42!gegeweb.eu!gegeweb.org!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <rowen-2FDD9C.13521710112011@news.gmane.org>
References: <rowen-2FDD9C.13521710112011@news.gmane.org>
From: Ian Kelly <ian.g.kelly@gmail.com>
Date: Thu, 10 Nov 2011 15:35:14 -0700
Subject: Re: Decorator question: prefer class, but only function works
To: "Russell E. Owen" <rowen@uw.edu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: python-list@python.org
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.2627.1320964546.27778.python-list@python.org>
Lines: 57
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:15565

On Thu, Nov 10, 2011 at 2:52 PM, Russell E. Owen <rowen@uw.edu> wrote:
> I am trying to write a decorator that times an instance method and
> writes the results to a class member variable. For example:
>
> def timeMethod(func):
> =A0 =A0def wrapper(self, *args, **keyArgs):
> =A0 =A0 =A0 =A0t1 =3D time.time()
> =A0 =A0 =A0 =A0res =3D func(self, *args, **keyArgs)
> =A0 =A0 =A0 =A0duration =3D time.time() - t1
> =A0 =A0 =A0 =A0self.timings[func.__name__] =3D duration
> =A0 =A0 =A0 =A0return res
> =A0 =A0return wrapper
>
> This works, but I'm not very happy with the way self.timings is obtained.

What do you feel is wrong with it?  You probably should use
sum(os.times()[:2]) instead, which (assuming your script is
single-threaded) will more accurately count the actual CPU time spent
in the function rather than real time, which could be quite different
if the CPU is busy.

Also, why do you need this?  If you're just trying to evaluate the
speed of your code, you should consider using a proper profiler or the
timeit module.  The former will tell you how much time is spent in
each function, while the latter runs the code a large number of times
in a loop, which gives you better precision for quick methods.

> I first tried to write this as a class (for readability), and this did
> NOT work:
>
> class timeMethod(object):
> =A0 =A0def __init__(self, func):
> =A0 =A0 =A0 =A0self.func =3D func
> =A0 =A0def __call__(self, *args, **keyArgs):
> =A0 =A0 =A0 =A0t1 =3D time.time()
> =A0 =A0 =A0 =A0res =3D self.func(*args, **keyArgs)
> =A0 =A0 =A0 =A0duration =3D time.time() - t1
> =A0 =A0 =A0 =A0args[0].timings.set(self.func.__name__, duration)
> =A0 =A0 =A0 =A0return res
>
> In the first case the wrapper is called as an unbound function, so it
> works. But in the second case the wrapper is called as a bound method --
> thus args[0] is not func's class instance, and I can't get to the
> timings attribute.

I prefer the function version myself, but to make this work you could
add something like this (untested) to make your wrapper class a
descriptor that tacks on the self argument:

    def __get__(self, instance, owner):
        from functools import partial
        if instance is None:
            return self
        return partial(self, instance)

HTH,
Ian