Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed2.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <687dea63-84da-4c45-9366-cb5a10665d1f@googlegroups.com>
References: <687dea63-84da-4c45-9366-cb5a10665d1f@googlegroups.com>
Date: Mon, 3 Jun 2013 03:20:52 +1000
Subject: Re: PyWart: The problem with "print"
From: Chris Angelico <rosuav@gmail.com>
To: python-list@python.org
Content-Type: text/plain; charset=ISO-8859-1
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.2551.1370193662.3114.python-list@python.org>
Lines: 50
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:46711

On Mon, Jun 3, 2013 at 3:04 AM, Rick Johnson
<rantingrickjohnson@gmail.com> wrote:
>  * Woefully inadequate because: Switching on or off the debug
>    messages is only valid in the current module that the
>    function was imported. What if you want to kill all
>    debugprint messages EVERYWHERE? Do you really want to edit
>    "debug = BOOLEAN" in every source file OR do something
>    stupid like import debugprint and edit the DEBUG constant
>    OR even dumber, edit the debugprint source code? GAWD NO!

Easy fix to this one. Instead of copying and pasting debugprint into
everything, have it in a module and import it everywhere. Then the
debug flag will be common to them all.

Oh, and you probably want to add **kwargs to debugprint, because the
print function does a lot more than sys.stdout.write does:

>>> print(1,2,3,4,sep='#')
1#2#3#4

>  * But even if you are willing to cope with all the "switch-
>    on-and-off" nonsense, are you willing to have you code
>    slowed by numerous calls to a dead function containing a
>    comparison that will always be false?

Hmm. Could be costly. Hey, you know, Python has something for testing that.

>>> timeit.timeit('debugprint("asdf")','def debugprint(*args):\n\tif not DEBUG: return\n\tprint(*args)\nDEBUG=False',number=1000000)
0.5838018519113444

That's roughly half a second for a million calls to debugprint().
That's a 580ns cost per call. Rather than fiddle with the language,
I'd rather just take this cost. Oh, and there's another way, too: If
you make the DEBUG flag have effect only on startup, you could write
your module thus:

if DEBUG:
  debugprint=print
else:
  def debugprint(*args,**kwargs):
    pass

So you can eliminate part of the cost there, if it matters to you. If
a half-microsecond cost is going to be significant to you, you
probably should be looking at improving other areas, maybe using
ctypes/cython, or possibly playing with the new preprocessor tricks
that have been being discussed recently. There's really no need to
change the language to solve one specific instance of this "problem".

ChrisA