Path: csiph.com!usenet.pasdenom.info!gegeweb.org!de-l.enfer-du-nord.net!feeder1.enfer-du-nord.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
DomainKey-Signature: a=rsa-sha1; c=nofws; d=feete.org; h=message-id:date:from :mime-version:to:subject:references:in-reply-to:content-type: content-transfer-encoding; q=dns; s=feete.org; b=J0zr02/IbWPOJyr ZWEZ4bM9vXWkqQi8jKaGHvQ1myffoNQa8MCPTl9hWhED+z1VuP8hsCC13fXfCNqB 6tHnQ3VLnYVMBci2zb/VLVT03lkjkWBW+CEzs+NGeSvfTDD4PambacbdjeKTPMr8 9TeMOp2wzM+ofRQyiESBYgnM8RQQ=
Date: Sat, 21 Jul 2012 20:34:48 +0100
From: Ian Foote <ian@feete.org>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: python-list@python.org
Subject: Re: My first ever Python program, comments welcome
References: <pZqdnadVUa-EY5fNnZ2dnUVZ7rednZ2d@bt.com>
In-Reply-To: <pZqdnadVUa-EY5fNnZ2dnUVZ7rednZ2d@bt.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.2394.1342899297.4697.python-list@python.org>
Lines: 85
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:25763

On 21/07/12 20:08, Lipska the Kat wrote:
> Greetings Pythoners
>
> A short while back I posted a message that described a task I had set 
> myself. I wanted to implement the following bash shell script in Python
>
> Here's the script
>
> sort -nr $1 | head -${2:-10}
>
> this script takes a filename and an optional number of lines to display
> and sorts the lines in numerical order, printing them to standard out.
> if no optional number of lines are input the script prints 10 lines
>
> Here's the file.
>
> 50    Parrots
> 12    Storage Jars
> 6    Lemon Currys
> 2    Pythons
> 14    Spam Fritters
> 23    Flying Circuses
> 1    Meaning Of Life
> 123    Holy Grails
> 76    Secret Policemans Balls
> 8    Something Completely Differents
> 12    Lives of Brian
> 49    Spatulas
>
>
> ... and here's my very first attempt at a Python program
> I'd be interested to know what you think, you can't hurt my feelings
> just be brutal (but fair). There is very little error checking as you 
> can see and I'm sure you can crash the program easily.
> 'Better' implementations most welcome
>
> #! /usr/bin/env python3.2
>
> import fileinput
> from sys import argv
> from operator import itemgetter
>
> l=[]
> t = tuple
What is this line supposed to do? If you're trying to make an empty 
tuple, you can write:
     t = ()
But I don't think this is needed at all.
> filename=argv[1]
> lineCount=10
>
> with fileinput.input(files=(filename)) as f:
>     for line in f:
>         t=(line.split('\t'))
>         t[0]=int(t[0])
>         l.append(t)
>     l=sorted(l, key=itemgetter(0))
>
>     try:
>         inCount = int(argv[2])
>         lineCount = inCount
I don't think you need to split this into two lines here.
         try:
             lineCount = int(argv[2])
should work.
>     except IndexError:
>         #just catch the error and continue
>         None
I would use pass instead of None here - I want to "do nothing" rather 
than create a None object.
>     for c in range(lineCount):
>         t=l[c]
>         print(t[0], t[1], sep='\t', end='')
>
> Thanks
>
> Lipska
>

My only other point is that you might find it helpful to use slightly 
more verbose names than l or t - its not immediately obvious to the 
reader what these are intended to represent.

Regards,
Ian