Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Date: Wed, 17 Oct 2012 10:36:38 -0400
From: Dave Angel <d@davea.name>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: rusi <rustompmody@gmail.com>
Subject: Re: list comprehension question
References: <CA+C4C6f=24oD4seHY_-h1F0GMvBTWNYbzTABXOdtKkAZtE9hdQ@mail.gmail.com> <507E145E.9060008@davea.name> <CA+C4C6cjha4bMZ9gyx5fTp0c_nfFQxRGu31dGNMjgHQBu73=ig@mail.gmail.com> <mailman.2341.1350477185.27098.python-list@python.org> <61d76114-3021-4a3b-9943-1e81147d3ce1@6g2000pbh.googlegroups.com>
In-Reply-To: <61d76114-3021-4a3b-9943-1e81147d3ce1@6g2000pbh.googlegroups.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: python-list@python.org
Precedence: list
Reply-To: d@davea.name
Newsgroups: comp.lang.python
Message-ID: <mailman.2348.1350484621.27098.python-list@python.org>
Lines: 36
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:31512

On 10/17/2012 10:06 AM, rusi wrote:
> On Oct 17, 5:33 pm, Dave Angel <d...@davea.name> wrote:
>> On 10/17/2012 12:43 AM, Kevin Anthony wrote:> Is it not true that list comprehension is much faster the the for loops?
>>
>>> If it is not the correct way of doing this, i appoligize.
>>> Like i said, I'm learing list comprehension.
>> list comprehensions CAN be much faster, but not necessarily.  The most
>> complex a loop, the less likely it'll help much.
> One-lining the comprehension seems to make a difference of about 10%
> out here. Maybe Ive missed something? Seems too large…
>
> # My original suggestion
> def dot(p,q): return sum (x*y for x,y in zip(p,q))
> def transpose(m): return zip(*m)
> def mm(a,b): return mmt(a, transpose(b))
> def mmt(a,b): return [[dot(ra, rb) for rb in b] for ra in a]
>
> # One-liner (Thanks Hans for reminding me of sum)
>
> def mm1(a,b): return [[sum([x*y for x,y in zip(ra,rb)]) for rb in
> zip(*b)] for ra in a]
>
>>>> t1=Timer("res=mm1(m,m)", setup="from __main__ import mm1, m")
>>>> t1.timeit(1000)
> 12.276363849639893
>>>> t0=Timer("res=mm(m,m)", setup="from __main__ import mm, m")
>>>> t0.timeit(1000)
> 13.453603029251099

And I'd wager all the improvement is in the inner loop, the dot() function.


-- 

DaveA