Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Date: Fri, 24 May 2013 15:29:27 -0400
From: Dave Angel <davea@davea.name>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
MIME-Version: 1.0
To: python-list@python.org
Subject: Re: Read txt file, add to iptables not working on new host
References: <puAnt.800936$OJ2.639894@en-nntp-11.dc1.easynews.com> <mailman.2067.1369403653.3114.python-list@python.org> <FCMnt.5938$4E1.5852@en-nntp-08.dc1.easynews.com>
In-Reply-To: <FCMnt.5938$4E1.5852@en-nntp-08.dc1.easynews.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.2075.1369423780.3114.python-list@python.org>
Lines: 35
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:45913

On 05/24/2013 12:32 PM, JackM wrote:
> So Chris, does this version look better? Changed to inFile to with.
>
>
> #!/usr/bin/python
> import os
> import time
>
> # Input, Output, and TimeStamp
> logFile = open('/var/www/html/statistics/logs/banList.log','w')
> stamp = time.asctime(time.localtime())
>
> # Daily Flush of blockList rules before re-applying Blocks
> os.popen('/sbin/iptables -F INPUT')
> logFile.write(stamp+'\nFlushing Rules..\n')
>
> # Loop to read in file and Apply rules to IPtables
> with open('/var/www/html/mydomain.com/banlist.txt','r') as inFile:
>      for line in inFile:  # TODO: Use 'with' for a bit of protection
>          ip = line.split(';')[0]

You want to write the command to the logfile here, BEFORE you try the 
popen().  That way if there's a problem, you can see what it was about 
to try before it crashed.

>          output = os.popen( '/sbin/iptables -A INPUT -s ' + ip + ' -j
> REJECT' )
>          logFile.write(ip+' - Has been blocked\n')
>
>
>
>

-- 
DaveA