Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Return-Path: <wayne@waynewerner.com>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.011
X-Spam-Evidence: '*H*': 0.98; '*S*': 0.00; 'pop': 0.05; 'skip:` 30': 0.09; 'did:': 0.16; 'dig': 0.16; 'fine.': 0.16; 'help?': 0.16; 'parameter,': 0.16; 'posix': 0.16; 'subprocess': 0.16; 'weird.': 0.16; 'certainly': 0.17; 'thanks,': 0.18; 'code.': 0.20; 'subject:) ': 0.20; 'trying': 0.21; 'import': 0.21; 'os,': 0.22; 'work.': 0.23; "i've": 0.23; 'seems': 0.23; 'header:User-Agent:1': 0.26; 'fine': 0.28; 'issues.': 0.29; 'reviews,': 0.29; 'source': 0.29; "i'm": 0.29; 'worked': 0.30; 'code': 0.31; 'could': 0.32; 'getting': 0.33; 'skip:s 30': 0.33; 'function.': 0.33; 'anyone': 0.33; 'to:addr:python-list': 0.33; 'otherwise.': 0.35; 'board': 0.35; 'subject:?': 0.35; 'but': 0.36; 'should': 0.36; 'charset:us- ascii': 0.36; 'subject: (': 0.36; 'does': 0.37; 'things': 0.38; 'nothing': 0.38; 'gives': 0.39; 'to:addr:python.org': 0.39; 'where': 0.40; 'story': 0.61; 'more': 0.63; 'here': 0.65; '"hey,': 0.84; 'from:addr:wayne': 0.84
Date: Thu, 11 Oct 2012 18:10:12 -0500 (CDT)
From: Wayne Werner <wayne@waynewerner.com>
X-X-Sender: wayne@gilgamesh
To: python-list@python.org
Subject: Posix call (execve) breaks mercurial?
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <http://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <http://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.2072.1349997039.27098.python-list@python.org>
Lines: 29
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1349997039 news.xs4all.nl 6891 [2001:888:2000:d::a6]:41524
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:31138

So... this is certainly the deepest I've got to dig into any source code.

I'm experimenting with Review Board for code reviews, and trying to get it 
set up/working here at work. When using post-review, however, I started 
getting issues with untrusted users - even though they were set to trusted 
in my ~/.hgrc and things worked fine otherwise.

So here's where things got weird. I could call 
`subprocess.check_output(['hg', 'root'])`, and things worked just fine. 
But when I added the env parameter, I got the untrusted issues. So if I 
did:

import os, subprocess

# Works just fine
subprocess.check_output(['hg', 'root'])

# Gives untrusted issues
subprocess.check_output(['hg', 'root'], env=os.environ)


Long story short, I dug around the source code and ended up at the POSIX 
execve function. I've been reading the manpages, but nothing seems to pop 
out at me as "hey, this should/shouldn't work!".

Does anyone know what's going on here, or where I should go for more help?

Thanks,
Wayne