Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed3a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Return-Path: <ian.g.kelly@gmail.com>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.013
X-Spam-Evidence: '*H*': 0.97; '*S*': 0.00; 'lawrence': 0.09; 'patch.': 0.09; 'yeah,': 0.09; 'python': 0.11; 'bug': 0.12; "wouldn't": 0.14; 'changes': 0.15; 'formatting.': 0.16; 'fix': 0.17; 'wrote:': 0.18; 'wed,': 0.18; 'feb': 0.22; 'proposed': 0.22; 'looks': 0.24; 'header:In-Reply-To:1': 0.27; 'specifically': 0.29; 'fixed': 0.29; 'url:bugs': 0.29; 'am,': 0.29; 'message-id:@mail.gmail.com': 0.30; 'code': 0.31; '25,': 0.31; 'url:python': 0.33; 'community': 0.33; 'test': 0.35; 'received:google.com': 0.35; 'url:org': 0.36; 'wrong': 0.37; 'to:addr:python-list': 0.38; 'to:addr:python.org': 0.39; 'affect': 0.61; 'break': 0.61; '2015': 0.84; 'otten': 0.84
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=qxzHv47mfQWHoMnmT+bnXJItPhP/PwUBXxNqmsUifdc=; b=nayv5VBXWU1ws8oUgJtyaduFonJIGLwzs1Ae+w34R5y4W//tLRAnuqA3mIgEJsgIud kT3X1KAy/l+DT6Arvk0BuijSzBfA8WutgXusNiceiTGT2KvgXYMtL+BagUsi+FmlJUFj hnpG9TR24FOPTdA4DFiMXEmlZOi2HS8ujFPVGIfPFZ2j7WQJpXaMtrHeH49tuPSI4CVq vNrdm9c6l1/LBA3ax6Gy9h48s3sk3XbG3D4RLSeHK1qgZlcvkGU/CPxCvgqhj8vH3Rkw 0Wxy2LlSzd5kng2jtNKVpvjvK3qYt5fguLpxVP90QcT91lDLH3HsB+9kqvNSh1WA9iW4 W/XA==
X-Received: by 10.70.38.163 with SMTP id h3mr8231539pdk.95.1424893365087; Wed, 25 Feb 2015 11:42:45 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <mcl0am$2g3$1@ger.gmane.org>
References: <1cf84559-3a63-4799-a879-ae8e513d387e@googlegroups.com> <mckke8$con$1@ger.gmane.org> <mckrpt$j10$1@ger.gmane.org> <mckupu$acd$1@ger.gmane.org> <mcl0am$2g3$1@ger.gmane.org>
From: Ian Kelly <ian.g.kelly@gmail.com>
Date: Wed, 25 Feb 2015 12:42:04 -0700
Subject: Re: Bug in timsort!?
To: Python <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.19212.1424893367.18130.python-list@python.org>
Lines: 14
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1424893367 news.xs4all.nl 2864 [2001:888:2000:d::a6]:43088
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:86436

On Wed, Feb 25, 2015 at 10:21 AM, Peter Otten <__peter__@web.de> wrote:
> Mark Lawrence wrote:
>
>> Reading the bug report http://bugs.python.org/issue23515, specifically
>> msg236586, it looks as if the proposed fix was wrong and one of the
>> smarter members of the python community fixed it.
>
> If I understand that correctly Benjamin's modifications don't affect the
> functionality of the patch.

Yeah, just looks like some changes for code clarity to me.

Py_ssize_t is signed, so the n-1 > 0 test wouldn't break on n = 0. The
other changes are pure formatting.