Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed1.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.071 X-Spam-Evidence: '*H*': 0.86; '*S*': 0.00; 'fix.': 0.09; 'cc:addr :python-list': 0.11; '*with': 0.16; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'fix': 0.17; 'wrote:': 0.18; 'wed,': 0.18; 'feb': 0.22; 'cc:addr:python.org': 0.22; 'cc:2**0': 0.24; 'source': 0.25; 'tracker': 0.26; 'header:In-Reply-To:1': 0.27; 'patch': 0.29; 'message-id:@mail.gmail.com': 0.30; "i'm": 0.30; '25,': 0.31; 'though.': 0.31; 'but': 0.35; 'received:google.com': 0.35; 'really': 0.36; 'should': 0.36; 'mine': 0.38; 'question,': 0.38; 'issue': 0.38; 'pm,': 0.38; 'that,': 0.38; 'little': 0.38; 'does': 0.39; 'decided': 0.64; 'worth': 0.66; 'evaluate': 0.72; 'touch': 0.74; '2015': 0.84; 'to:none': 0.92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=w0JtwrWVMOY+R6gOXqYHZ2Pd49fYITYphbAXtIQhLI8=; b=MR2zF2hvpWtiLH9JAiYjskTjt3MtLMATDzQzLL4BxoiejDghj9iAy2xpI9b8SImrEv Wu5w12owlYsq+vwvTcRDSLYynqp0yRaPHoC9qteg9FgBRIppb6uTYnK6evdhKDr76MlA K07dy18mwQm6F/u3KWKMGtwpTKCWavAgcjcD6NaphqWt7z5+XFaApHRWl7fgz8Nld7wq sO19KNpI2CghfEYxo3RVesTA3HiwhNlU1gHovZxBsh9u1lCB9RBUlgFRSGK8vMRYlLvt s+3uwvoR6+vYBW831Aa3u3v2xA9nwHya9wN2+nkDvD1SpiPTWK+8bORPdb7sII0V+pQC 6BxQ== MIME-Version: 1.0 X-Received: by 10.107.128.219 with SMTP id k88mr3380050ioi.27.1424859116082; Wed, 25 Feb 2015 02:11:56 -0800 (PST) In-Reply-To: References: <1cf84559-3a63-4799-a879-ae8e513d387e@googlegroups.com> <54ED0B7E.7030801@mrabarnett.plus.com> Date: Wed, 25 Feb 2015 21:11:55 +1100 Subject: Re: Bug in timsort!? From: Chris Angelico Cc: "python-list@python.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 12 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1424859125 news.xs4all.nl 2883 [2001:888:2000:d::a6]:45691 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:86391 On Wed, Feb 25, 2015 at 8:10 PM, Paddy wrote: > If we are given a proven fix *with little downside* then if we are to touch the source then we should MAKE THE FIX. (emphasis mine) That's really the question, though. I'm in no position to evaluate the patch and ascertain whether the fix does indeed have little or no downside. But as the tracker issue proves, a greater mind than mine has decided that it's to be applied, which means that, yes, it's worth doing. ChrisA