Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed4a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.017 X-Spam-Evidence: '*H*': 0.97; '*S*': 0.00; ';-)': 0.03; 'cpython': 0.05; 'python': 0.11; '"python': 0.16; '-1;': 0.16; '24,': 0.16; 'function"': 0.16; 'roy': 0.16; 'wrote:': 0.18; 'feb': 0.22; 'header:In-Reply-To:1': 0.27; 'function': 0.29; 'message- id:@mail.gmail.com': 0.30; '3.2': 0.31; 'break;': 0.31; 'struct': 0.31; 'implemented': 0.33; 'something': 0.35; 'received:google.com': 0.35; 'url:eu': 0.37; 'to:addr:python- list': 0.38; 'pm,': 0.38; 'does': 0.39; 'to:addr:python.org': 0.39; 'smith': 0.68; '2015': 0.84; 'edwards': 0.91 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=FfnfwZUJ/nVJzZYnQYAoRWKvRRe8vNGkF/FaBGL3uTM=; b=XVEFmffNLozjPvINo029BGLz4wKge/6b84Q8isieUyASq6B7nAwa3NKs3Qa2RpjS/I GQOSxcYFvGLiolX6ehBWDz/QCD9nAea5t83Jg5tMHT45uqLVT4/hNO+bxamGiA658yPg MD4LZrW9zvRZGx7ceMOkkhOx6XHvsaaEghk7zRHaOtDqiLoBrmcnSN43kxMs1EEFx62p pimwpmG42yU7l+okRWmfm/bUqKbuqSDJAouZ0oSu7LyUsI+uR0FSmoOVP8qg7fjnqnFh gXH3AzcGmKgAHzid0EH15b5WAvO6hL3FVBknHfIR4Q7P1syEThkRTkt/v9H3ZAMa339x lEUw== X-Received: by 10.70.130.37 with SMTP id ob5mr425121pdb.72.1424818814627; Tue, 24 Feb 2015 15:00:14 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1cf84559-3a63-4799-a879-ae8e513d387e@googlegroups.com> From: Ian Kelly Date: Tue, 24 Feb 2015 15:59:34 -0700 Subject: Re: Bug in timsort!? To: Python Content-Type: text/plain; charset=UTF-8 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 36 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1424819247 news.xs4all.nl 2967 [2001:888:2000:d::a6]:51078 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:86352 On Tue, Feb 24, 2015 at 3:45 PM, Grant Edwards wrote: > On 2015-02-24, Roy Smith wrote: > >> http://envisage-project.eu/proving-android-java-and-python-sorting-algorithm-is-broken-and-how-to-fix-it/ > > I don't get it. > > 3.2 Corrected Python merge_collapse function > > merge_collapse(MergeState *ms) > { > struct s_slice *p = ms->pending; > > assert(ms); > while (ms->n > 1) { > Py_ssize_t n = ms->n - 2; > if ( n > 0 && p[n-1].len <= p[n].len + p[n+1].len > || (n-1 > 0 && p[n-2].len <= p[n].len + p[n-1].len)) { > if (p[n-1].len < p[n+1].len) > --n; > if (merge_at(ms, n) < 0) > return -1; > } > else if (p[n].len <= p[n+1].len) { > if (merge_at(ms, n) < 0) > return -1; > } > else > break; > } > return 0; > } > > Or does "Python function" mean something else in this context? Recall that CPython is implemented in C. ;-)