Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed2a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.000 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'from:addr:yahoo.co.uk': 0.04; 'that?': 0.05; 'context': 0.07; 'correct.': 0.07; 'lawrence': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'subject:method': 0.09; 'try:': 0.09; 'python': 0.11; 'language.': 0.14; 'corrupt': 0.16; 'does,': 0.16; 'exit.': 0.16; 'knock': 0.16; 'lite': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'sqlite': 0.16; 'sat,': 0.16; 'language': 0.16; 'wrote:': 0.18; 'feb': 0.22; '>>>': 0.22; 'import': 0.22; 'header:User-Agent:1': 0.23; 'certainly': 0.24; 'looks': 0.24; 'header:X-Complaints-To:1': 0.27; 'header:In-Reply- To:1': 0.27; 'point': 0.28; 'raise': 0.29; "doesn't": 0.30; 'file': 0.32; 'says': 0.33; 'url:python': 0.33; 'level.': 0.33; 'subject:the': 0.34; 'subject:with': 0.35; 'connection': 0.35; 'except': 0.35; 'skip:s 60': 0.36; 'url:org': 0.36; 'manager': 0.38; 'url:library': 0.38; 'to:addr:python-list': 0.38; 'does': 0.39; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'managers': 0.61; 'url:3': 0.61; "you're": 0.61; 'you.': 0.62; 'our': 0.64; 'charset:windows-1252': 0.65; 'here': 0.66; 'close': 0.67; '2015': 0.84; 'subject:try': 0.84 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Mark Lawrence Subject: Re: try pattern for database connection with the close method Date: Sun, 22 Feb 2015 19:07:03 +0000 References: <6trfeate2ppvm1mcapgr0g4g2fd3vceab6@4ax.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: host-92-24-222-48.ppp.as43234.net User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 46 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1424632052 news.xs4all.nl 2831 [2001:888:2000:d::a6]:38622 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:86145 On 22/02/2015 18:41, Mario Figueiredo wrote: > On Sat, 21 Feb 2015 12:22:58 +0000, Mark Lawrence > wrote: > >> >> Use your context manager at the outer level. >> >> import sqlite3 as lite >> >> try: >> with lite.connect('data.db') as db: >> try: >> db.execute(sql, parms) >> except lite.IntegrityError: >> raise ValueError('invalid data') >> except lite.DatabaseError: >> raise OSError('database file corrupt or not found.') > > The sqlite context manager doesn't close a database connection on > exit. It only ensures, commits and rollbacks are performed. > Where in the documentation does it state that? If it does, it certainly breaks my expectations, as I understood the whole point of Python context managers is to do the tidying up for you. Or have you misread what it says here https://docs.python.org/3/library/sqlite3.html#using-the-connection-as-a-context-manager ? >>> import sqlite3 >>> with sqlite3.connect(r'C:\Users\Mark\Documents\Cash\Data\cash.sqlite') as db: ... db.execute('select count(*) from accounts') ... >>> db.close() >>> Looks like you're correct. Knock me down with a feather, Clevor Trevor. -- My fellow Pythonistas, ask not what our language can do for you, ask what you can do for our language. Mark Lawrence