Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed3a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <mca84m$bg0$1@ger.gmane.org>
References: <6trfeate2ppvm1mcapgr0g4g2fd3vceab6@4ax.com> <mc9tbf$62d$1@ger.gmane.org> <CALwzidmKzZutwKQ-pddx_6YHPTqoix8Fod-JX=YF38dYBSyThQ@mail.gmail.com> <mca84m$bg0$1@ger.gmane.org>
From: Ian Kelly <ian.g.kelly@gmail.com>
Date: Sat, 21 Feb 2015 08:50:08 -0700
Subject: Re: try pattern for database connection with the close method
To: Python <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.18973.1424533852.18130.python-list@python.org>
Lines: 23
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:86050

On Sat, Feb 21, 2015 at 8:27 AM, Peter Otten <__peter__@web.de> wrote:
> Ian Kelly wrote:
>
>> On Sat, Feb 21, 2015 at 5:22 AM, Mark Lawrence <breamoreboy@yahoo.co.uk>
>> wrote:
>>> try:
>>>     with lite.connect('data.db') as db:
>>>     try:
>>>         db.execute(sql, parms)
>>>     except lite.IntegrityError:
>>>         raise ValueError('invalid data')
>>> except lite.DatabaseError:
>>>     raise OSError('database file corrupt or not found.')
>>
>> This could result in the OSError being misleadingly raised due to some
>> DatabaseError raised by the execute rather than the connect.
>
> The OP probably wants to catch these DatabaseErrors, too. Also, the chance
> of a misleading traceback has been greatly reduced with the advent of
> chained exceptions.
>

Yes, but the point is that OSError is probably inappropriate in that case.