Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed1a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
To: python-list@python.org
From: Mark Lawrence <breamoreboy@yahoo.co.uk>
Subject: Re: try pattern for database connection with the close method
Date: Sat, 21 Feb 2015 12:22:58 +0000
References: <6trfeate2ppvm1mcapgr0g4g2fd3vceab6@4ax.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
In-Reply-To: <6trfeate2ppvm1mcapgr0g4g2fd3vceab6@4ax.com>
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.18955.1424521415.18130.python-list@python.org>
Lines: 46
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:86026

On 21/02/2015 02:42, Mario Figueiredo wrote:
> Hello all,
>
> I'm using the following pattern for db access  that requires me to
> close the connection as soon as it is not needed:
>
>          import sqlite3 as lite
>
>          try:
>              db = lite.connect('data.db')
>          except lite.DatabaseError:
>              raise OSError('database file corrupt or not found.')
>          else:
>              try:
>                  with db:
>                      db.execute(sql, parms)
>              except lite.IntegrityError:
>                  raise ValueError('invalid data')
>              finally:
>                  db.close()
>
> Since it's a bit verbose, is there a better way?
>
> Note: The user of this API has the whole database functionality
> abstracted away. Hence the exception channeling in the except clauses.
>

Use your context manager at the outer level.

import sqlite3 as lite

try:
     with lite.connect('data.db') as db:
     try:
         db.execute(sql, parms)
     except lite.IntegrityError:
         raise ValueError('invalid data')
except lite.DatabaseError:
     raise OSError('database file corrupt or not found.')

-- 
My fellow Pythonistas, ask not what our language can do for you, ask
what you can do for our language.

Mark Lawrence