Path: csiph.com!usenet.pasdenom.info!news.franciliens.net!fdn.fr!usenet-fr.net!nerim.net!novso.com!newsfeed.xs4all.nl!newsfeed4a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'received:209.85.223': 0.03; 'odd': 0.07; 'string': 0.09; 'instance.': 0.09; 'integers': 0.09; 'skip:% 20': 0.09; 'subject:version': 0.09; 'cc:addr:python- list': 0.11; 'bug': 0.12; 'accepting': 0.14; '4.10': 0.16; '4.9': 0.16; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'normally,': 0.16; 'ought': 0.16; 'really?': 0.16; 'tuple': 0.16; 'fix': 0.17; 'wrote:': 0.18; 'feb': 0.22; '(in': 0.22; 'cc:addr:python.org': 0.22; 'fixed.': 0.24; 'looks': 0.24; 'cc:2**0': 0.24; 'tracker': 0.26; 'header:In-Reply-To:1': 0.27; 'am,': 0.29; 'raise': 0.29; 'needed.': 0.30; 'message- id:@mail.gmail.com': 0.30; 'that.': 0.31; '13,': 0.31; 'comparison': 0.31; 'fault': 0.31; 'follows': 0.31; 'skip:q 20': 0.31; 'supposed': 0.32; 'fri,': 0.33; 'problem': 0.35; 'received:209.85': 0.35; 'skip:s 30': 0.35; 'but': 0.35; 'received:google.com': 0.35; 'version': 0.36; 'format.': 0.36; 'scheme': 0.36; 'too': 0.37; 'received:209': 0.37; 'system,': 0.38; 'expect': 0.39; 'even': 0.60; "you're": 0.61; 'more': 0.64; '2015': 0.84; 'presumably': 0.84; 'to:none': 0.92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=vBUZNau1vihCD5ekkWi1Yv6wqpShIDeD5foKCf7o0oo=; b=fxZKGsjv6cA7P1+Jj8FHn1h9MHyDH61pnibuc9Vgrlcuj8p+xj9ruDXBABObJ076Pt krctucgncPL8Tg4rHOcPKXJRCVpNdziv93OZkdBxPqcHswVpM09p+dSmJMwsfL8LQqtK BVxsZhvvbvQSxMyYXX00dgLrKlufjLPBVLY9wevEdYx267CVQGT2uephFIPPDWP4Ge7Q nFPFU3BYv6C5n4x2QFzSD55tExkYn57fXldufWYiodf7xuQ4P/qpPK6JRhIe/Ac7wpss MBiRpefhWkW0VnEd1PQhLhhMAMZqKNqIaj7ARGjDp+KxpXa+NOse2NmLaMvflS4KTyv8 47VA== MIME-Version: 1.0 X-Received: by 10.50.62.110 with SMTP id x14mr5136183igr.2.1423760316425; Thu, 12 Feb 2015 08:58:36 -0800 (PST) In-Reply-To: <54DCD8A5.9050907@yahoo.no> References: <54DCD8A5.9050907@yahoo.no> Date: Fri, 13 Feb 2015 03:58:36 +1100 Subject: Re: Odd version scheme From: Chris Angelico Cc: Python-list Content-Type: text/plain; charset=UTF-8 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 22 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1423760318 news.xs4all.nl 2871 [2001:888:2000:d::a6]:48563 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:85592 On Fri, Feb 13, 2015 at 3:45 AM, Gisle Vanem wrote: > Looking at Ipython's check (in site-packages\IPython\external\qt.py): > if QtCore.PYQT_VERSION_STR < '4.7': > raise ImportError("IPython requires PyQt4 >= 4.7, found > %s"%QtCore.PYQT_VERSION_STR) > > So even if '4.10' < '4.7', my '4.10' is newer. What odd version scheme is > this really? I just edited that line to read: > if QtCore.PYQT_VERSION_STR < '4.10': Looks to me like a fault in comparison format. Normally, you'd expect that 4.10 follows 4.9 - that is, that the version number is a tuple of integers - but this is attempting a naive string comparison on it. Check for an ipython bug tracker and report the matter; that ought to be fixed. Bear in mind that your change now means that you're accepting too much - for instance. '4.6' is not less than '4.10', even though it's supposed to be rejecting that. Presumably this won't be a problem on your own system, but for upstream, a more reliable fix will be needed. ChrisA