Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed2.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.004 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'expected.': 0.09; 'false,': 0.09; 'from:addr:ethan': 0.09; 'from:addr:stoneleaf.us': 0.09; 'from:name:ethan furman': 0.09; 'grid': 0.09; 'message- id:@stoneleaf.us': 0.09; '~ethan~': 0.09; 'def': 0.12; 'suggest': 0.14; 'blank,': 0.16; 'col': 0.16; 'filename:fname piece:signature': 0.16; 'iterating': 0.16; 'worst': 0.16; 'elements': 0.16; 'wrote:': 0.18; 'header:User-Agent:1': 0.23; 'header:In-Reply-To:1': 0.27; 'chris': 0.29; "doesn't": 0.30; 'strongly': 0.30; 'cells': 0.31; 'class': 0.32; 'probably': 0.32; 'skip:_ 10': 0.34; 'i.e.': 0.36; 'yield': 0.36; 'to:addr:python- list': 0.38; 'pm,': 0.38; 'does': 0.39; 'to:addr:python.org': 0.39; 'remove': 0.60; 'blank': 0.60; 'full': 0.61; 'entire': 0.61; 'received:173': 0.61; 'evaluate': 0.72; 'subject:skip:S 10': 0.84 Date: Tue, 10 Feb 2015 08:44:39 -0800 From: Ethan Furman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: python-list@python.org Subject: Re: __next__ and StopIteration References: <54d94307$0$12998$c3e8da3$5496439d@news.astraweb.com> <54D98A35.9060203@earthlink.net> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6NxSQ4V1l47SMH2rDxDfhL0JRuEukBTht" X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 58 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1423586718 news.xs4all.nl 2847 [2001:888:2000:d::a6]:42958 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:85455 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6NxSQ4V1l47SMH2rDxDfhL0JRuEukBTht Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/09/2015 08:46 PM, Chris Angelico wrote: >=20 > class Grid: > blah blah >=20 > def __iter__(self): > for row in range(self._rows): > for col in range(self._cols): > if self._grid[row][col]: > yield self._grid[row][col] I strongly suggest you remove the if self._grid[row][col]: line. Best case scenario: the entire grid is blank, and iterating through it do= es nothing. Worst case scenario: only some elements evaluate as False, so your loop = doesn't execute the full number of times; i.e. with a grid of 4x5 with 7 blank cells you get 13 iterations -- probably n= ot what was expected. -- ~Ethan~ --6NxSQ4V1l47SMH2rDxDfhL0JRuEukBTht Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJU2jV7AAoJENZ7D1rrH75NJkgP/38mrVWyR3o7/Z7hy7r6k/Fp yhxvat4epkkqod6amZGa5SKDsmzeHv9plzVFM5bftHj+Nbm/DKPllmoyglUTyQG6 0kZ77k37sxEEkH7yP3c+UXqsjVmJ0Cxo0YsPNa2fsqazQYXpUjmH5up964wk3X1D HPo8Q1TiYzp1lrpm6aMABish4zI37koSM5OhA8E20/chz5AtzD7oWc8J+BF7+BwW mNI64IW/DFbWhMGciogntnquUjFw69AgvFoyb7aku9iUeBnlYImZrij1x0n5z4Ig 2lnQS+5taGCQTRo/nKKokuGoBYyG+6B4w4eeeH3NLnb39WYtnVD8+wMLHZ33Skm/ RuLa99qyPnR636oL5dFDbxMYYxQOBCRkyUjKUw+aeEx1TKLGS/xM+mQDru/HoUCU g6Wbf/JbRomM+Rt1qEY9Nu/sDl8r+0g45FwPcvHYdJE/m8c+czwd6VLioe7fRtux gZpuiAhGWmQVhOzkqGzNz3msv10ddE9qGr80xeMtU5WnT9/Ohs34tLaeeugfb8Mc 6xh/qCqj+PBEGSP6oINHYglc5hRGVfPfGdiGYtLmIT0apG/da59ahyrwDdz6W7dP XygsoOmWmy+HO3fgtD1j+okRnT0kvEoiaU/OZxvciYF8grxxKIUd+ONYThzHmAjN KVP7XQ1/6r2UFEunGvl9 =Fpoy -----END PGP SIGNATURE----- --6NxSQ4V1l47SMH2rDxDfhL0JRuEukBTht--