Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!newsfeed.xs4all.nl!newsfeed1a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'else:': 0.03; 'attribute': 0.07; '22,': 0.09; 'host,': 0.09; 'http': 0.09; 'lawrence': 0.09; 'mercurial': 0.09; 'shows.': 0.09; 'underscore': 0.09; 'url:github': 0.09; 'api': 0.11; 'def': 0.12; 'bug': 0.12; 'jan': 0.12; 'language.': 0.14; 'changes': 0.15; 'https': 0.16; 'kindest': 0.16; "method's": 0.16; 'proxy,': 0.16; 'url:bugzilla': 0.16; 'url:py': 0.16; 'url:redhat': 0.16; 'url:show_bug': 0.16; 'thursday,': 0.16; 'language': 0.16; 'thanks,': 0.17; 'wrote:': 0.18; 'trying': 0.19; 'thu,': 0.19; 'work,': 0.20; '>>>': 0.22; 'error': 0.23; 'first,': 0.26; 'post': 0.26; 'header:In-Reply- To:1': 0.27; 'url:bugs': 0.29; '[1]': 0.29; 'raise': 0.29; 'thus': 0.29; "doesn't": 0.30; '[2]': 0.30; 'message-id:@mail.gmail.com': 0.30; 'url:mailman': 0.30; 'code': 0.31; "skip:' 10": 0.31; 'filed': 0.31; 'second,': 0.31; 'trace': 0.31; 'file': 0.32; 'checked': 0.32; 'url:python': 0.33; 'skip:_ 10': 0.34; 'could': 0.34; 'skip:s 30': 0.35; 'but': 0.35; 'received:google.com': 0.35; 'right?': 0.36; 'url:listinfo': 0.36; 'method': 0.36; 'url:org': 0.36; 'should': 0.36; 'behind': 0.37; 'january': 0.37; 'reports': 0.37; 'list': 0.37; 'system,': 0.38; 'handle': 0.38; 'to:addr :python-list': 0.38; 'issue': 0.38; 'list,': 0.38; 'pm,': 0.38; 'does': 0.39; 'reported': 0.39; 'to:addr:python.org': 0.39; 'url:mail': 0.40; 'break': 0.61; 'first': 0.61; "you've": 0.63; 'name': 0.63; 'our': 0.64; 'regards.': 0.65; 'details': 0.65; 'reply': 0.66; 'caused': 0.69; '2015': 0.84; 'url:cpython': 0.84; 'anymore,': 0.95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Xsr1VHyMakwgbNOmsaReEXK5p8H06tm50jtBvnIZr7E=; b=MqbVN7Q5OXUUzTbkdjzZ2TQRLskZm65XNn1R8RmjmoZSuv9oWmni0H3L7PshiqZS0g 1iDMvsTE+JTDz5sIm3aIxNHAkZmyiZ5T0VkChaLbGRQFe294dyjkPbhEgof9AXU1s1jA ygn0Hod50UqamoiMOXRVjJIp3fPA1nCA8RUSENaT+lONr2itndW+r8lM+PQiVWxn8p6a pQ5E6YyMIj7y0ODNbBJF+ocF8tiGbeX9dVBvoaWeSgrwJEhdr1YV2ARHjS4Jv4l+EGxr 5Wi43C5gs2e3Rz/qQH/VwKP7F8YCQ356JV+MKYSHSdD02TOmia3sKmql3NAtPNGfKJGa hKjg== MIME-Version: 1.0 X-Received: by 10.140.39.116 with SMTP id u107mr7256005qgu.98.1421966152092; Thu, 22 Jan 2015 14:35:52 -0800 (PST) In-Reply-To: <112947510.5511972.1421928291463.JavaMail.yahoo@jws11124.mail.ir2.yahoo.com> References: <112947510.5511972.1421928291463.JavaMail.yahoo@jws11124.mail.ir2.yahoo.com> Date: Fri, 23 Jan 2015 06:35:52 +0800 Subject: Re: An improper change in httplib.py From: Guohua Ouyang To: python-list@python.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 73 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1421966154 news.xs4all.nl 2830 [2001:888:2000:d::a6]:49529 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:84285 Have reported an issue http://bugs.python.org/issue23300. "That leading underscore in the method name means it is not a public API and thus changes are allowed without any backwards-compatibility guarantees. Mercurial will need to update their code to handle this if they want to continue to use the method." I checked the official mercurial repo, it does not use the method anymore, so I filed a bug to fedora. [1] [1] https://bugzilla.redhat.com/show_bug.cgi?id=1185105 On Thu, Jan 22, 2015 at 8:04 PM, Mark Lawrence wrote: > No problem, but out of courtesy could you please reply to the list and not > just me. > > Kindest regards. > > Mark Lawrence. > > > On Thursday, 22 January 2015, 11:51, Guohua Ouyang > wrote: > > > > thanks, file the issue 23300 > > On Thu, Jan 22, 2015 at 5:06 PM, Mark Lawrence > wrote: >> On 22/01/2015 03:38, Guohua Ouyang wrote: >>> >>> This is my first post to the list, I apologies firstly if I made any >>> mistake. >>> >>> I was trying to get a package in golang behind the http or https >>> proxy, and it reports an error "AttributeError: httpsconnection >>> instance has no attribute '_set_hostport'", details in the bottom. >>> After some trace work, I found it caused by the changes in the issue >>> issue7776. >>> >>> @@ -718,7 +734,7 @@ >>> else: >>> self._tunnel_headers.clear() >>> >>> - def _set_hostport(self, host, port): >>> + def _get_hostport(self, host, port): >>> >>> First, it changes the method's name, doesn't it break the >>> compatibility for other packages, on my system, >>> mercurial-3.0-2.fc21.x86_64 still use "_set_hostport" as the error >>> shows. >>> >>> Second, I found that line 1132 of [2] still use " >>> self._conn._set_hostport(host, port)", which should be >>> "_get_hostport", right? >>> >>> [1] http://bugs.python.org/issue7776 >>> [2] https://github.com/python/cpython/blob/2.7/Lib/httplib.py >> >> >> You've found a bug so please raise it on bugs.python.org :) >> >> -- >> My fellow Pythonistas, ask not what our language can do for you, ask >> what you can do for our language. >> >> Mark Lawrence >> >> -- >> https://mail.python.org/mailman/listinfo/python-list > >