Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.000 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'else:': 0.03; 'from:addr:yahoo.co.uk': 0.04; 'attribute': 0.07; 'host,': 0.09; 'http': 0.09; 'lawrence': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'shows.': 0.09; 'url:github': 0.09; 'def': 0.12; 'bug': 0.12; 'language.': 0.14; 'changes': 0.15; 'https': 0.16; "method's": 0.16; 'proxy,': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'url:py': 0.16; 'language': 0.16; 'wrote:': 0.18; 'trying': 0.19; 'work,': 0.20; 'header:User-Agent:1': 0.23; 'error': 0.23; 'first,': 0.26; 'post': 0.26; 'header:X-Complaints-To:1': 0.27; 'header:In-Reply- To:1': 0.27; 'url:bugs': 0.29; '[1]': 0.29; 'raise': 0.29; "doesn't": 0.30; '[2]': 0.30; "skip:' 10": 0.31; 'second,': 0.31; 'trace': 0.31; 'url:python': 0.33; 'skip:_ 10': 0.34; 'skip:s 30': 0.35; 'right?': 0.36; 'url:org': 0.36; 'should': 0.36; 'behind': 0.37; 'reports': 0.37; 'system,': 0.38; 'to:addr:python-list': 0.38; 'issue': 0.38; 'list,': 0.38; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'break': 0.61; 'first': 0.61; "you've": 0.63; 'our': 0.64; 'charset:windows-1252': 0.65; 'details': 0.65; 'caused': 0.69; 'url:cpython': 0.84 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Mark Lawrence Subject: Re: An improper change in httplib.py Date: Thu, 22 Jan 2015 09:06:31 +0000 References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: host-92-24-222-48.ppp.as43234.net User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 35 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1421917607 news.xs4all.nl 2837 [2001:888:2000:d::a6]:49797 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:84213 On 22/01/2015 03:38, Guohua Ouyang wrote: > This is my first post to the list, I apologies firstly if I made any mistake. > > I was trying to get a package in golang behind the http or https > proxy, and it reports an error "AttributeError: httpsconnection > instance has no attribute '_set_hostport'", details in the bottom. > After some trace work, I found it caused by the changes in the issue issue7776. > > @@ -718,7 +734,7 @@ > else: > self._tunnel_headers.clear() > > - def _set_hostport(self, host, port): > + def _get_hostport(self, host, port): > > First, it changes the method's name, doesn't it break the > compatibility for other packages, on my system, > mercurial-3.0-2.fc21.x86_64 still use "_set_hostport" as the error > shows. > > Second, I found that line 1132 of [2] still use " > self._conn._set_hostport(host, port)", which should be > "_get_hostport", right? > > [1] http://bugs.python.org/issue7776 > [2] https://github.com/python/cpython/blob/2.7/Lib/httplib.py You've found a bug so please raise it on bugs.python.org :) -- My fellow Pythonistas, ask not what our language can do for you, ask what you can do for our language. Mark Lawrence