Path: csiph.com!usenet.pasdenom.info!news.albasani.net!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Return-Path: <tyler@tysdomain.com>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.012
X-Spam-Evidence: '*H*': 0.98; '*S*': 0.00; 'subject:code': 0.07; 'given,': 0.09; 'language,': 0.11; 'thread': 0.11; 'language': 0.14; 'feedback.': 0.15; 'code?': 0.16; 'from:addr:tyler': 0.16; 'from:addr:tysdomain.com': 0.16; 'from:name:littlefield, tyler': 0.16; 'message-id:@tysdomain.com': 0.16; 'received:69.164': 0.16; 'received:69.164.206': 0.16; 'received:69.164.206.65': 0.16; 'received:tds-solutions.net': 0.16; 'thread.': 0.16; 'wrote:': 0.17; 'basically': 0.17; 'appears': 0.18; 'code.': 0.20; 'info.': 0.22; "i've": 0.23; 'header:In-Reply-To:1': 0.25; 'header:User- Agent:1': 0.26; 'appear': 0.26; 'looks': 0.26; 'wondering': 0.26; 'appreciated.': 0.26; 'topic': 0.27; 'instead.': 0.27; 'rest': 0.28; 'dialog': 0.29; 'project:': 0.29; 'yes.': 0.29; 'url:code': 0.29; 'feedback': 0.30; 'helpful': 0.30; 'code': 0.31; 'submitting': 0.32; 'could': 0.32; 'info': 0.32; 'to:addr:python- list': 0.33; 'third': 0.34; 'thanks': 0.34; 'doing': 0.35; 'pm,': 0.35; 'received:192.168.0': 0.35; 'there': 0.35; 'really': 0.36; "wasn't": 0.36; "didn't": 0.36; 'should': 0.36; 'does': 0.37; 'well.': 0.37; 'subject:: ': 0.38; 'some': 0.38; 'to:addr:python.org': 0.39; 'received:192': 0.39; 'where': 0.40; 'received:192.168': 0.40; 'your': 0.60; 'bottom': 0.60; 'most': 0.61; 'mentioned': 0.63; 'url:p': 0.63; 'more': 0.63; 'gone': 0.64; 'started.': 0.65; 'watching': 0.65; 'light-weight': 0.84; 'reading,': 0.84; 'care,': 0.91
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on wuff
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable version=3.3.1
Date: Tue, 03 Jul 2012 23:39:20 -0600
From: "Littlefield, Tyler" <tyler@tysdomain.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: python-list@python.org
Subject: Re: code review
References: <mailman.1623.1340939177.4697.python-list@python.org> <6c39594f-79cb-4d4f-967e-bbc3f68cdbdf@f8g2000pbf.googlegroups.com> <4fed59b7$0$29978$c3e8da3$5496439d@news.astraweb.com> <mailman.1631.1340982202.4697.python-list@python.org> <EaAHr.369967$of1.132220@fx06.am4> <CAH8GtdMUdrpK=O5fXSBs1Xn8CmA4qZiCqN8+PJ=CZnv8jJCYUg@mail.gmail.com> <CALwzidn=8E_rvx1xdwEEx4tgz8-7ZgHnbXt65JefG=q4xkoR3Q@mail.gmail.com> <16ab546d-79e8-4d9a-9f8b-a28494d885f7@email.android.com> <CAPTjJmrGmPajNKXsgTCUXwn3MbctGHysBcE-3BpfrjRuocgkWA@mail.gmail.com> <4FF3CCCD.8070309@fossworkflowguides.com>
In-Reply-To: <4FF3CCCD.8070309@fossworkflowguides.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <http://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <http://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.1776.1341380373.4697.python-list@python.org>
Lines: 43
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1341380373 news.xs4all.nl 6935 [2001:888:2000:d::a6]:45036
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:24848

On 7/3/2012 10:55 PM, Simon Cropper wrote:
> Some questions to Tyler Littlefield, who started this thread.
>
> Q1 -- Did you get any constructive feedback on your code?

I did get some, which I appreciated. someone mentioned using PyLint. 
 From reading, I found it was really really pedantic, so I used PyFlakes 
instead.
>
> Q2 -- Did you feel that the process of submitting your code for review 
> met your expectation?

There wasn't much more to review, so yes. The info I got was helpful and 
farther than it was before I started.

> Q3 -- Would you recommend others doing this either on this forum or 
> other fora?
>
> It appears to me - third party watching the ongoing dialog - that the 
> tread has gone right off topic (some time ago) and someone should 
> really start a new thread under a new title/subject. Most of what I 
> have read does not appear to be discussing your code or how you could 
> improve your code.
>
I basically just stopped after a while. It got into a my language is 
better than your language, so I didn't see much constructive info. I've 
started reading from the bottom though, where it looks like it's back, 
and I do appreciate the rest of the info given, as well. Thanks again 
for the feedback.

> Following the last few posts, I was wondering whether some other 
> off-list dialog is going on or whether I am missing something.
>


-- 
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.